Update splink demos #1407
Merged
Update splink demos #1407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test: test_2_rounds_1k_duckdbPercentage change: -22.9%
Test: test_2_rounds_1k_sqlitePercentage change: -14.6%
Click here for vega lite time series charts |
4 tasks
|
The scope of this PR has been scaled back to just manage the changing file structure of splink_demos. The rendering will be dealt with separately after the migration of tutorials and examples to this repo |
|
@ThomasHepworth given the splink_demos PR has been merged, can you give this a quick approve to update the folder structure here |
Comment on lines
+97
to
+99
| - Deduplicate 50k rows historical persons: "demos/examples/duckdb/deduplicate_50k_synthetic.ipynb" | ||
| - Linking financial transactions: "demos/examples/duckdb/transactions.ipynb" | ||
| - Linking two tables of persons: "demos/examples/duckdb/link_only.ipynb" |
There was a problem hiding this comment.
Do we want to include the deterministic dedupe anywhere in here?
There was a problem hiding this comment.
Ah, yea that was an oversight on my part
There was a problem hiding this comment.
will add before merging
ThomasHepworth
approved these changes
Jul 13, 2023
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of PR
Is your Pull Request linked to an existing Issue or Pull Request?
Closes #1332
Related splink demos PR moj-analytical-services/splink_demos#92
Give a brief description for the solution you have provided
The tutorial and example notebooks are in need of an update, and bringing mkdocs.yml into line with new folder structure of splink_demos. In addition, the rendering of charts has been broken for a while so that also needs fixed.
PR Checklist