Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add path arguments to automated tests #1595

Merged
merged 4 commits into from
Sep 13, 2023

Conversation

ThomasHepworth
Copy link
Contributor

@ThomasHepworth ThomasHepworth commented Sep 11, 2023

Type of PR

  • BUG
  • FEAT
  • MAINT
  • DOC

Is your Pull Request linked to an existing Issue or Pull Request?

#1594

Give a brief description for the solution you have provided

This PR adds a check to see whether file changes have occurred in either the splink or tests subfolders, before running our automated tests.

You can see this below where only four actions have been triggered by this PR.

PR Checklist

  • Added documentation for changes
  • Added feature to example notebooks or tutorial (if appropriate)
  • Added tests (if appropriate)
  • Made changes based off the latest version of Splink
  • Run the linter

Copy link
Contributor

@ADBond ADBond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this! It's annoyed me for a while that we have all these tests running on e.g. an update to the docs, but never occurred to me to actually do anything about it

.github/workflows/pytest_benchmark_comment.yml Outdated Show resolved Hide resolved
@ADBond
Copy link
Contributor

ADBond commented Sep 12, 2023

One another thing: I suppose we might want to trigger the tests when we update dependencies as well, so might be worth also adding them to the paths?

@ThomasHepworth ThomasHepworth merged commit 60283fa into master Sep 13, 2023
@ThomasHepworth ThomasHepworth deleted the only_run_tests_on_splink_edits branch September 13, 2023 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Only run tests if files under splink or tests have been edited
2 participants