Splink 4 blocking rule/blocking rule creator fixes #2103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobinL
changed the title
RobinL
changed the title
RobinL
force-pushed
the
blocking_rule_fixes
branch
from
5699007
to
6afe412
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a variety of linker functions that take blocking rules as an argument directly (i.e. not as part of the settings object) e.g.
count_num_comparisons_from_blocking_ruleThis PR ensures these functions accept a
BlockingRuleCreator(i.e. fromblock_on), and do not accept aBlockingRule(which is now internal and shouldn't be used by end users)I created a new file
blocking_rule_creator_utils.pyprimarily because of problems with circular imports.I found many of these problems when doing the example/tutorials notebooks and left
TODOs to fix. There's no need to check the modifications to them, as I'm just reverting the code in them to what it should have been in the first place