Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stricter mypy checks #2108

Merged
merged 32 commits into from
Apr 2, 2024
Merged

Stricter mypy checks #2108

merged 32 commits into from
Apr 2, 2024

Conversation

ADBond
Copy link
Contributor

@ADBond ADBond commented Mar 28, 2024

Stricter use of mypy:

  • removing some excluded modules (i.e. no longer excluded)
  • remove a softer checking parameter we had (following imports)
  • add in a few stricter checking options (a subset of full --strict mode - see the relevant docs)

Nothing particularly special about the set of options I have added - just following the mypy suggested route, and stopped at a point before the changeset became too large (maybe? sorry if I missed that point!).
We can continue incrementally adding remaining options in follow-ups as and when.

In terms of the code changes to get this up to spec, I don't think there is anything particularly crazy here. Much of it is adding/correcting annotations + renaming variables, but there are a few genuine code changes - don't think anything noteworthy however.

@ADBond ADBond changed the base branch from splink4_dev to mypy-more-files March 28, 2024 10:06
@ADBond ADBond changed the base branch from mypy-more-files to splink4_dev March 28, 2024 10:06
@ADBond ADBond changed the title [WIP] Stricter mypy checks Stricter mypy checks Mar 28, 2024
@ADBond ADBond requested a review from RobinL March 28, 2024 12:55
Copy link
Member

@RobinL RobinL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great - thanks!

@ADBond ADBond merged commit 70fe50c into splink4_dev Apr 2, 2024
11 checks passed
@ADBond ADBond deleted the stricter-mypying branch April 2, 2024 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants