-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stricter mypy checks #2108
Merged
Merged
Stricter mypy checks #2108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ADBond
force-pushed
the
stricter-mypying
branch
from
March 28, 2024 11:46
c7f1ee9
to
03a38ac
Compare
RobinL
approved these changes
Apr 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great - thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stricter use of mypy:
--strict
mode - see the relevant docs)Nothing particularly special about the set of options I have added - just following the mypy suggested route, and stopped at a point before the changeset became too large (maybe? sorry if I missed that point!).
We can continue incrementally adding remaining options in follow-ups as and when.
In terms of the code changes to get this up to spec, I don't think there is anything particularly crazy here. Much of it is adding/correcting annotations + renaming variables, but there are a few genuine code changes - don't think anything noteworthy however.