Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor fixes to spellchecker #2113

Merged
merged 2 commits into from
Mar 28, 2024
Merged

Minor fixes to spellchecker #2113

merged 2 commits into from
Mar 28, 2024

Conversation

zslade
Copy link
Contributor

@zslade zslade commented Mar 28, 2024 •
edited
Loading

Type of PR

  • BUG
  • FEAT
  • MAINT
  • DOC

Is your Pull Request linked to an existing Issue or Pull Request?

Give a brief description for the solution you have provided

Updating guidance with comments from PR #2025 and correcting one mistake

PR Checklist

  • Added documentation for changes
  • Added feature to example notebooks or tutorial (if appropriate)
  • Added tests (if appropriate)
  • Updated CHANGELOG.md (if appropriate)
  • Made changes based off the latest version of Splink
  • Run the linter

@zslade zslade marked this pull request as ready for review March 28, 2024 16:24
ThomasHepworth
ThomasHepworth approved these changes Mar 28, 2024
View reviewed changes
Copy link
Contributor

@ThomasHepworth ThomasHepworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hooray!

@zslade zslade merged commit 5d7ea7c into master Mar 28, 2024
8 checks passed
@zslade zslade deleted the spellchecker_fix branch March 28, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThomasHepworth ThomasHepworth ThomasHepworth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zslade @ThomasHepworth