Faster tests: Split out tests into separate backends and use altair 5.3.0 #2117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobinL
changed the title
|
Todo: |
RobinL
commented
Mar 30, 2024
| @@ -16,6 +16,7 @@ | |||
| from .linker_utils import _test_write_functionality, register_roc_data | |||
|
|
|||
|
|
|||
| @mark_with_dialects_including("spark") | |||
There was a problem hiding this comment.
marked spark because otherwise this ran as part of core tests, which slowed down the core/duckdb tests significantly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The aim of this PR is:
Results:
I have double checked the tests which run. The diff shows that this new structure runs (strictly) more tests than before, because previously we were not running
sqlitemarked tests anywhere. All previous tests are still run.Caching of poetry environments is now explicitly supported by the official setup-python action
I have now split out the tests as follows:
I have also upgraded to the latest altair (5.3.0) to make sure we use the performance improvements I did to alt.Chart.from_dict