Restore Settings Validation (Splink 4) #2127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ADBond
force-pushed
the
settings-validation-splink4
branch
2 times, most recently
from
00d2d95
to
85ea454
Compare
ADBond
force-pushed
the
settings-validation-splink4
branch
from
85ea454
to
abaa23b
Compare
ADBond
changed the title
RobinL
approved these changes
Apr 4, 2024
|
The linting issue was fixed by the autoblack commit - couldn't figure out a way to easily re-trigger CI checks unfortunately! |
|
Oh yeah - of course. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously while work on
Settings/SettingsCreatoretc were occurring the settings validation code was unhooked.This restores that code, while deleting the portions that I don't think are relevant, now that we are not dealing with dictionaries (by the time the
Settingsis instantiated).It may well make sense to rewrite some of this code ultimately to fit more naturally in line with the new way we are constructing things, but for now it seems reasonable to restore the functionality we had, before perhaps moving the logic around.
Feel free to disagree with what I've removed/whether this makes sense overall.