Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add better check for whether conda is already installed #2130

Merged
merged 1 commit into from
Apr 4, 2024
Merged

Add better check for whether conda is already installed #2130

merged 1 commit into from
Apr 4, 2024

Conversation

zmbc
Copy link
Contributor

@zmbc zmbc commented Apr 3, 2024

Type of PR

  • BUG
  • FEAT
  • MAINT
  • DOC

Is your Pull Request linked to an existing Issue or Pull Request?

No.

Give a brief description for the solution you have provided

Noticed an additional bug in the conda script: it usually couldn't tell that I already had conda installed. Fixed that here.

PR Checklist

  • Added documentation for changes
  • Added feature to example notebooks or tutorial (if appropriate)
  • Added tests (if appropriate)
  • Updated CHANGELOG.md (if appropriate)
  • Made changes based off the latest version of Splink
  • Run the linter

RobinL
RobinL approved these changes Apr 4, 2024
View reviewed changes
Copy link
Member

@RobinL RobinL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great z thanks

@RobinL RobinL merged commit 4c9b2b9 into moj-analytical-services:master Apr 4, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobinL RobinL RobinL approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zmbc @RobinL