Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds runs for python versions 3.10, 3.11, and 3.12 to the backend tests in CI (and so is sort-of a long-delayed follow-up to #1090).
The previous issue with adding these was something to do with
numpy
versions. It seems that in the intervening time, the issue related to 3.10 + 3.11 has been resolved (I think this is probably to do with us updating the lockfile - I think the version of numpy we had locked had some issues on certain platforms with these versions).The version of
numpy
we now have in the lockfile though doesn't work with python 3.12 - it seems that poetry didn't recognise this incompatibility. So I have added numpy explicitly as a dependency - the minimum version (for python < 3.12) is the minimum accepted by our current minimumpandas
version. For python 3.12 I have added the minimumnumpy
release supporting it - and updated the lockfile with these new updates.I realise this results in quite a number of checks now, but they are fairly quick, so don't think this should be a huge burden. You can see the checks running in this PR on my fork - I have cherry-picked everything from that branch, except for a dummy code change I added to trigger CI.
Couple of other things here:
spark
tests don't run on 3.12, aspyspark
does not work with this version. There is a fix to add this compatibility added topyspark
, but it seems from the discussion there that this will not be arriving before Spark 4postgres
service dependency in one version only, and b) the abovepyspark
issue makes it a bit more fiddly. We can probably figure out something a bit neater down the line if wanted.Closes #1496.