-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding type-hints, part 1 #2169
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobinL
approved these changes
May 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Sorry for the merge problem, was just about to fix it but you've done it!
No worries - your PRs have been there a while so happy to sort out the merge - nothing major anyhow. Cheers! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly adding a bunch of type hints to the code base.
This gets rid of approximately half of the
mypy
errors we get if we include the flagdisallow_incomplete_defs
, and thus is a stepping stone to include that check in our config.The only noteworthy changes:
None
default forestimate_u_with_random_sampling
, as perlinker.estimate_u_using_random_sampling
fails with default arguments, with no clear indication why #2165 - needed some solution to avoid breakingmypy
checks, but we can change this again in follow-upsComparisonLevel
has a (read-only) propertycomparison_vector_value
- this is just a wrapper around the internal_comparison_vector_value
, that does not allow theNone
option we have before it is associated withComparison
. This is mostly what we want to use anyhow