Misc tidying #2182
Merged
Misc tidying #2182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Three small unrelated changes that weren't quite worth putting separately:
ColumnExpressiontyping to better clarify what allowed operations look likeComparisonCreator/ComparisonLevelCreatorOn the last point I am not convinced if these are necessarily the best place to have these functions (maybe the base classes make more sense, but then more complicated as we need to make reference to the subclasses
CustomXXXexplicitly), but I think the current structure is a bit confusing (ComparisonCreator._convert_to_creator()makes aComparisonLevelCreator), so now it is at least consistent across comparison + level.