Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust package top level imports #2269

Merged
merged 3 commits into from
Jul 18, 2024
Merged

Adjust package top level imports #2269

merged 3 commits into from
Jul 18, 2024

Conversation

ADBond
Copy link
Contributor

@ADBond ADBond commented Jul 18, 2024

  • Make all backend APIs available at splink.backends.XXX.XXXAPI
  • Only DuckDBAPI and SparkAPI importable from top-level splink

Also:

  • ignore .html files as default, particularly so I don't accidentally commit the one now generated in tests

@ADBond ADBond added the splink4 label Jul 18, 2024
@ADBond ADBond requested a review from RobinL July 18, 2024 09:45
RobinL
RobinL approved these changes Jul 18, 2024
View reviewed changes
Copy link
Member

@RobinL RobinL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ADBond ADBond merged commit ccb165e into splink4_dev Jul 18, 2024
25 checks passed
@ADBond ADBond deleted the adjust-top-level-imports branch July 18, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobinL RobinL RobinL approved these changes

Assignees
No one assigned
Labels
splink4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ADBond @RobinL