Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove jan 1st option from date of birth comparison #2281

Merged
merged 2 commits into from
Jul 23, 2024
Merged

Remove jan 1st option from date of birth comparison #2281

merged 2 commits into from
Jul 23, 2024

Conversation

RobinL
Copy link
Member

@RobinL RobinL commented Jul 23, 2024 •
edited
Loading

We have decided to remove this option for the moment because:

  • It adds a lot of complexity without any robust evidence it improves accuracy
  • We're not sure whether it should be 'phrased' as a match of 1st jan vs. any other day/month, or only exact match on 1st jan on both sides of the match
  • We're not sure of the extent to which you get similar results by just enabling term frequency adjustments

@RobinL RobinL requested a review from ADBond July 23, 2024 15:53
@RobinL RobinL changed the title remove jan 1st option from date of birth comparison Remove jan 1st option from date of birth comparison Jul 23, 2024
ADBond
ADBond approved these changes Jul 23, 2024
View reviewed changes
Copy link
Contributor

@ADBond ADBond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@RobinL RobinL merged commit 8283511 into splink4_dev Jul 23, 2024
25 checks passed
@RobinL RobinL deleted the date_of_birth_comparison_simplify branch July 23, 2024 16:48
@RobinL RobinL mentioned this pull request Jul 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ADBond ADBond ADBond approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RobinL @ADBond