Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small fixes #2285

Merged
merged 5 commits into from
Jul 23, 2024
Merged

Small fixes #2285

merged 5 commits into from
Jul 23, 2024

Conversation

ADBond
Copy link
Contributor

@ADBond ADBond commented Jul 23, 2024

Mostly deleting a bunch of TODOs that I don't think we really need to do anymore.

Minor actual code changes:

  • cache_uid consistently using ascii_uid
  • replaced repartition logic with simpler equivalent code (unless I have done something stupid)

@ADBond ADBond added the splink4 label Jul 23, 2024
@ADBond ADBond requested a review from RobinL July 23, 2024 16:53
RobinL
RobinL approved these changes Jul 23, 2024
View reviewed changes
Copy link
Member

@RobinL RobinL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@ADBond ADBond merged commit 572d29d into splink4_dev Jul 23, 2024
25 checks passed
@ADBond ADBond deleted the small-fixes branch July 23, 2024 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobinL RobinL RobinL approved these changes

Assignees
No one assigned
Labels
splink4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ADBond @RobinL