Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid attempting to cast Infinity to double for spark backend #2372

Conversation

bkitej-rw
Copy link
Contributor

@bkitej-rw bkitej-rw commented Sep 2, 2024

Type of PR

  • BUG
  • FEAT
  • MAINT
  • DOC

Is your Pull Request linked to an existing Issue or Pull Request?

closes #2371

Give a brief description for the solution you have provided

Ports solution applied to Splink 3.8.5 for same code to Splink 4.

PR Checklist

  • Added documentation for changes
  • Added feature to example notebooks or tutorial (if appropriate)
  • Added tests (if appropriate)
  • Updated CHANGELOG.md (if appropriate)
  • Made changes based off the latest version of Splink
  • Run the linter
  • Run the spellchecker (if appropriate)

@bkitej-rw bkitej-rw marked this pull request as draft September 2, 2024 21:01
@bkitej-rw bkitej-rw marked this pull request as ready for review September 2, 2024 21:12
@bkitej-rw bkitej-rw marked this pull request as draft September 2, 2024 21:12
@ADBond
Copy link
Contributor

ADBond commented Sep 3, 2024

Going to merge this into a branch, and then open a separate PR to merge into master.

@ADBond ADBond changed the base branch from master to bug/spark-infinity-double September 3, 2024 07:47
@ADBond ADBond marked this pull request as ready for review September 3, 2024 07:47
@ADBond ADBond merged commit 0fd2f5c into moj-analytical-services:bug/spark-infinity-double Sep 3, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Avoid casting Infinity to double for Spark backend
2 participants