Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cumulative BRs - minor tweaks to fix documentation and rr error #974

Merged
merged 1 commit into from
Jan 16, 2023
Merged

Cumulative BRs - minor tweaks to fix documentation and rr error #974

merged 1 commit into from
Jan 16, 2023

Conversation

ThomasHepworth
Copy link
Contributor

This addresses a minor bug with the reduction ratio not being correctly displayed and also updates the docs to be more consistent.

@github-actions
Copy link
Contributor

Test: test_2_rounds_1k_duckdb

Percentage change: -35.1%

date time stats_mean stats_min commit_info_branch commit_info_id machine_info_cpu_brand_raw machine_info_cpu_hz_actual_friendly commit_hash
849 2022-07-12 18:40:05 1.89098 1.87463 splink3 c334bb9 Intel(R) Xeon(R) Platinum 8370C CPU @ 2.80GHz 2.7934 GHz c334bb9
1314 2023-01-13 10:54:09 1.24778 1.21637 cumulative_br_adjustments d3ff8db Intel(R) Xeon(R) Platinum 8272CL CPU @ 2.60GHz 2.5939 GHz d3ff8db

Test: test_2_rounds_1k_sqlite

Percentage change: -26.2%

date time stats_mean stats_min commit_info_branch commit_info_id machine_info_cpu_brand_raw machine_info_cpu_hz_actual_friendly commit_hash
851 2022-07-12 18:40:05 4.32179 4.25898 splink3 c334bb9 Intel(R) Xeon(R) Platinum 8370C CPU @ 2.80GHz 2.7934 GHz c334bb9
1316 2023-01-13 10:54:09 3.14894 3.14423 cumulative_br_adjustments d3ff8db Intel(R) Xeon(R) Platinum 8272CL CPU @ 2.60GHz 2.5939 GHz d3ff8db

Click here for vega lite time series charts

@ThomasHepworth ThomasHepworth merged commit 562cfb2 into master Jan 16, 2023
@ThomasHepworth ThomasHepworth deleted the cumulative_br_adjustments branch January 16, 2023 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobinL RobinL RobinL approved these changes

@ADBond ADBond Awaiting requested review from ADBond

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ThomasHepworth @RobinL