Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vcpkg manifest #122

Merged
merged 4 commits into from
May 25, 2023
Merged

Vcpkg manifest #122

merged 4 commits into from
May 25, 2023

Conversation

mfellows
Copy link
Contributor

Pull Request Template

Description

Added a vcpkg manifest file (vcpkg.json) and VS2019 and 2022 batch files for setting up vcpkg and building all dependencies in manifest mode - this allows us to use a slightly newer May 2022 vcpkg and finally upgrade to GDAL 3.4.3.

Does not break the previous build procedure, which can still be used.

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Built on two different local machines, both running Windows 10, one with VS2022 and the other with VS2019.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings
  • I have tagged the reviewers in a comment below incase my pull request is ready for a review
  • I have signed the commit message to agree to Developer Certificate of Origin (DCO) (to certify that you wrote or otherwise have the right to submit your contribution to the project.) by adding "--signoff" to my git commit command.

…2022 only for now) using FLINT\vcpkg\vcpkg_setup_vs2022_win_x64.bat.

OpenSSL will occasionally fail to build on some machines - if this happens, keep re-running cmake until it gets through (could take several tries).
@mfellows mfellows merged commit f0d82c1 into develop May 25, 2023
@mfellows mfellows deleted the vcpkg_manifest branch May 25, 2023 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant