Feature/check for 404 #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
March 12, 2020 19:03
…there is a communication error with the target oracle endpoint.
…UNICATION_ERROR` && `NOTFOUND.CODE` to be `DESTINATION_FSP_ERROR` instead of `PARTY_NOT_FOUND`
# Conflicts:
# src/models/oracle/facade.js
# test/unit/handlers/participants/{Type}/{ID}.test.js
# test/unit/handlers/participants/{Type}/{ID}/{SubId}.test.js
# test/unit/handlers/parties/{Type}/{ID}.test.js
# test/unit/handlers/parties/{Type}/{ID}/{SubId}.test.js
rmothilal
requested changes
Mar 13, 2020
lewisdaly
previously approved these changes
Mar 15, 2020
rmothilal
approved these changes
Mar 16, 2020
This was referenced Dec 19, 2023
This was referenced Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the returned error code on the Mowali edge case of
DESTINATION_COMMUNICATION_ERROR&NOTFOUND.CODEto beDESTINATION_FSP_ERRORinstead ofPARTY_NOT_FOUND