feat(mojaloop/3018): [SDK-Scheme-Adapter] TransactionId is being used…

… instead of TransferId (#148) feat(mojaloop/3018): [SDK-Scheme-Adapter] TransactionId is being used instead of TransferId - mojaloop/project#3018 - removed transactionId as required from bulkTransaction Individual Transfer Accept PUT callback (for both accept parties & quotes) - added transferId as required to bulkTransaction Individual Transfer Accept PUT callback (for both accept parties & quotes) - Removed bulkHomeTransaction, homeTransaction, and transaction Id's for bulkTransactions Accept PUT callback (for both accept parties & quotes) - Rebuild API specification definitions BREAKING CHANGE: transferId is now required on bulkTransaction Individual Transfer Accept PUT callback (for both accept parties & quotes), and bulkHomeTransaction, homeTransaction, and transaction Id' have been removed.
mojaloop · Nov 11, 2022 · af6c1e2 · af6c1e2
1 parent 287930f
commit af6c1e2
Show file tree

Hide file tree

Showing 13 changed files with 1,118 additions and 1,126 deletions.
diff --git a/.ncurc.js b/.ncurc.js
@@ -3,5 +3,7 @@ module.exports = {
     // Upgrading past husky@4 to involves a full config migration with no current and apparent benefit.
     // So we are just sticking to husky@4.x.x for the time being.
     'husky',
+    // Transpiler currently fails. TODO: Story to investigate and fix.
+    'openapi-typescript'
   ]
 }
diff --git a/docs/sdk-scheme-adapter-inbound-v2_0_0-openapi3-snippets.yaml b/docs/sdk-scheme-adapter-inbound-v2_0_0-openapi3-snippets.yaml
@@ -1614,6 +1614,7 @@ paths:
                     type: object
                     required: &ref_76
                       - homeTransactionId
+                      - transferId
                       - to
                       - amountType
                       - currency

diff --git a/docs/sdk-scheme-adapter-outbound-v2_0_0-openapi3-snippets.yaml b/docs/sdk-scheme-adapter-outbound-v2_0_0-openapi3-snippets.yaml
@@ -1802,15 +1802,8 @@ paths:
                     autoAcceptParty is false.
                   type: object
                   required: &ref_34
-                    - bulkHomeTransactionID
                     - individualTransfers
                   properties: &ref_35
-                    bulkHomeTransactionID:
-                      type: string
-                      description: >-
-                        Transaction ID from the DFSP backend, used to reconcile
-                        transactions between the Switch and DFSP backend
-                        systems.
                     individualTransfers:
                       description: >-
                         List of individual transfers in a bulk transfer with
@@ -1824,13 +1817,7 @@ paths:
                               Data model for the 'individualTransfer' while
                               accepting party or quote.
                             properties: &ref_30
-                              homeTransactionId:
-                                type: string
-                                description: >-
-                                  Transaction ID from the DFSP backend, used to
-                                  reconcile transactions between the Switch and
-                                  DFSP backend systems.
-                              transactionId:
+                              transferId:
                                 title: CorrelationId
                                 type: string
                                 pattern: >-
@@ -1847,8 +1834,7 @@ paths:
                                   dashes (‘-‘).
                                 example: b51ec534-ee48-4575-b6a9-ead2955b8069
                             required: &ref_31
-                              - homeTransactionId
-                              - transactionId
+                              - transferId
                           - type: object
                             required: *ref_28
                             properties: *ref_29
@@ -1857,15 +1843,8 @@ paths:
                     autoAcceptQuotes is false.
                   type: object
                   required: &ref_37
-                    - bulkHomeTransactionID
                     - individualTransfers
                   properties: &ref_38
-                    bulkHomeTransactionID:
-                      type: string
-                      description: >-
-                        Transaction ID from the DFSP backend, used to reconcile
-                        transactions between the Switch and DFSP backend
-                        systems.
                     individualTransfers:
                       description: List of individual transfers in a bulk transfer.
                       type: array