-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: sort SDK backend api, upgrade dependencies and fix inbound misnomer #150
Conversation
kleyow commented: |
0_0 |
😄 |
related to this PR |
you have renamed the API but not the file |
kleyow commented: I'll do the file/folder rename in my sorting PR since that is a non functional change PR. |
can you not create a snapshot release to check that? |
kleyow commented: |
kleyow commented: Though, since the backend openapi is in the TTKs for solely in the functional tests for bulk. Creating a snapshot of api-snippets won't really help. I also need to ask @vijayg10 how we can load spec files from api-snippets so we can use that as our source of truth. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
vijayg10 commented: |
vijayg10 commented: |
manually updated to the api definitions for the TTK Backend |
Since the functional tests are running against the updated backend api definition |
ok approved the wrong PR |
kleyow commented: |
kleyow commented: |
Approved PR #149 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- 1
kleyow commented: |
oh right |
No description provided.