Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: sync DFSP backend api with sdk adapter #149

Closed
wants to merge 6 commits into from

Conversation

kleyow
Copy link
Contributor

@kleyow kleyow commented Dec 14, 2022

I'm going to rename the misnomer of "inbound" with "backend" in another PR.

Pay attention mostly to sdk-scheme-adapter/v2_0_0/inbound/openapi.yaml

To bring api-snippets and sdk-scheme-adapter in sync I had to sort the yaml for easier comparsion, leading to huge diff.

The backend openapi in api snippets was a proper snapshot of the Backend Api before the bulk work was started.
I'm not sure how the backend openapi's that we used in the TTK's got desynced with the backend openapi that was living there before bulk.

Mainly changes to this openapi definition was

  • Added the newly added bulk endpoints.
  • Fix sub id url param
  • Add in missing components found in TTK spec that we're using for bulk functional tests
  • Add operation Id's which are useful for DFSP's

Main things I found here and not in sdk-scheme-adapter.

  • Existence of get /transfers that existed here but not in the sdk
  • Some ilppacket work here but not in the sdk
  • Differing fulfilNotification component that sdk. I believe the one here is the correct and latest one.

@kleyow kleyow changed the title chore: sync DFSP backend with sdk adapter chore: sync DFSP backend api with sdk adapter Dec 14, 2022
@@ -1,10 +1,15 @@
openapi: 3.0.1
info:
title: Mojaloop SDK Inbound Scheme Adapter API
title: Mojaloop SDK Adapter DFSP Backend API
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we are changing the title, shouldn't the file name also match?

Copy link
Member

@mdebarros mdebarros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

renaming file was address in this PR: #150

@kleyow kleyow closed this Dec 14, 2022
@kleyow kleyow deleted the chore/backend-api branch December 14, 2022 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants