Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mojaloop/3018): [SDK-Scheme-Adapter] TransactionId is being used instead of TransferId #148

Merged
merged 10 commits into from
Nov 11, 2022
Merged

feat(mojaloop/3018): [SDK-Scheme-Adapter] TransactionId is being used instead of TransferId #148

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
ed17c47
feat(mojaloop/3018): [SDK-Scheme-Adapter] TransactionId is being used…
mdebarros Nov 11, 2022
c404f1d
chore: update dependencies
mdebarros Nov 11, 2022
c672a9e
Revert "chore: update dependencies"
mdebarros Nov 11, 2022
d91f856
chore!: updated dependencies and breaking change bump
mdebarros Nov 11, 2022
76ea4b7
feat!: homeTransaction and bulkHomeTransaction Ids are now optional f…
mdebarros Nov 11, 2022
fdd3ad0
chore(snapshot): 17.0.0-snapshot.1
mdebarros Nov 11, 2022
52376d3
Revert "feat!: homeTransaction and bulkHomeTransaction Ids are now op…
mdebarros Nov 11, 2022
fb10624
feat!: updates to SDK inbound and outbound APIs for bulk
mdebarros Nov 11, 2022
722d645
chore(snapshot): 17.0.0-snapshot.2
mdebarros Nov 11, 2022
23d8303
updated dep
mdebarros Nov 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .ncurc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,7 @@ module.exports = {
// Upgrading past husky@4 to involves a full config migration with no current and apparent benefit.
// So we are just sticking to husky@4.x.x for the time being.
'husky',
// Transpiler currently fails. TODO: Story to investigate and fix.
'openapi-typescript'
]
}
1 change: 1 addition & 0 deletions docs/sdk-scheme-adapter-inbound-v2_0_0-openapi3-snippets.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1614,6 +1614,7 @@ paths:
type: object
required: &ref_76
- homeTransactionId
- transferId
- to
- amountType
- currency
Expand Down
25 changes: 2 additions & 23 deletions docs/sdk-scheme-adapter-outbound-v2_0_0-openapi3-snippets.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1802,15 +1802,8 @@ paths:
autoAcceptParty is false.
type: object
required: &ref_34
- bulkHomeTransactionID
- individualTransfers
properties: &ref_35
bulkHomeTransactionID:
type: string
description: >-
Transaction ID from the DFSP backend, used to reconcile
transactions between the Switch and DFSP backend
systems.
individualTransfers:
description: >-
List of individual transfers in a bulk transfer with
Expand All @@ -1824,13 +1817,7 @@ paths:
Data model for the 'individualTransfer' while
accepting party or quote.
properties: &ref_30
homeTransactionId:
type: string
description: >-
Transaction ID from the DFSP backend, used to
reconcile transactions between the Switch and
DFSP backend systems.
transactionId:
transferId:
title: CorrelationId
type: string
pattern: >-
Expand All @@ -1847,8 +1834,7 @@ paths:
dashes (‘-‘).
example: b51ec534-ee48-4575-b6a9-ead2955b8069
required: &ref_31
- homeTransactionId
- transactionId
- transferId
- type: object
required: *ref_28
properties: *ref_29
Expand All @@ -1857,15 +1843,8 @@ paths:
autoAcceptQuotes is false.
type: object
required: &ref_37
- bulkHomeTransactionID
- individualTransfers
properties: &ref_38
bulkHomeTransactionID:
type: string
description: >-
Transaction ID from the DFSP backend, used to reconcile
transactions between the Switch and DFSP backend
systems.
individualTransfers:
description: List of individual transfers in a bulk transfer.
type: array
Expand Down
Loading