-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Message template changes #1
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…central-notifications into messageTemplaeChanges
vgenev
approved these changes
Nov 20, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am happy with the changes
56 tasks
bothadeon
pushed a commit
that referenced
this pull request
Nov 27, 2018
* added timestamps in the datamodels and notification interval control * removed vsvode env directory from the central repo * Message template changes (#1) * Message template changes * added file ti gitignore * delete package-lock.json * Gitignore .idea * delete file * delete file * delete file * delete file * delete file * delete file * delete file * delete file * delete file * delete file * updated a typo * Fix/config (#4) * added readme.md and config to be available from environmental variables * added config doc * Added database docs (#5) * Added database docs * Added link in readme.md * Fix/env var (#6) * added readme.md and config to be available from environmental variables * added config doc * added config to take envvars for sensitive data, fixed directory name typo * fixed a config issue * added healthcheck * Feature/dockerize (#7) * Added Dockerfile * Added Dockerfile and dockerignore
vgenev
added a commit
that referenced
this pull request
Feb 8, 2019
* Develop (#8) * added timestamps in the datamodels and notification interval control * removed vsvode env directory from the central repo * Message template changes (#1) * Message template changes * added file ti gitignore * delete package-lock.json * Gitignore .idea * updated a typo * Fix/config (#4) * added readme.md and config to be available from environmental variables * added config doc * Added database docs (#5) * Added database docs * Added link in readme.md * Fix/env var (#6) * added readme.md and config to be available from environmental variables * added config doc * added config to take envvars for sensitive data, fixed directory name typo * fixed a config issue * added healthcheck * Feature/dockerize (#7) * Added Dockerfile * Added Dockerfile and dockerignore * updated readme * error catch * added mongo login information * uri of central ledger in config; healthcheckport -> PORT (#9) * mongodb findAndModify is a mess * typo fix * findandmodifyhell * kafka fix and log * changed /healtcheck to /health * typo fixe * changed package.json info and version * Added initial test to action model and pakage .json to run npm test * completed unit test on tha action model * completed unit test on tha current position model * Add unit tests for events model * Added unit tests for limits model * Added unit tests for notificationEndpoints model * Added unhappy line unit test for database.js * Fixed unhappy line unit test for database.js * Changes to unittest still failing * rewrite unit tests without mocha * rewrite unit tests without mocha mock a db connection * Added ne version of unit test * Fixed the leaked-handles issue * Added database.js unit test for unhappy line * unit test for actions added - incomplete * Added unit test to test if action is finish * added more unit testing to actions * More code for action unit test * added mocking for model.save() * Added unit tests to Actions observable * Added proxyquire to setup unit test * Added code for position change message * added methode for save event * Added code for save event and building params * added more changes to central ledgerAPI and currentpositions model * Added missing js in store * Finished the function to create current position record for settlement change * Finished code changes to centralLedgerApi * cleaned the enums; added action map for kafka and added email-notifier action; added Hub participant name as a config * finished 566 tasks.. time to test * changes for settlement position change implied * few fixes * merged something * ready to merge with master * fixed vulnerabilities * fixed package.json * added notification endpoint call for limits adjustment flow * removed few spaces * fixed opposite logic * fixed naming issue with event collection reference into the action model
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.