fix(mojaloop/#2644): missing error-code for the transfer in the central-ledger db #929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…al-ledger db - added transferError record insert into timeout Handler facade logic
…al-ledger db - chore: re-factored tests to use import paths - added test-case for `update transfer after timeout with timeout status & error`
kleyow
reviewed
Dec 9, 2022
kleyow
previously approved these changes
Dec 9, 2022
kleyow
previously approved these changes
Dec 9, 2022
- Added kafkaHelper to handle connection/disconnections in a standard way - Fixed bug with wrapWithRetries using a hard-coded sleep value - Added env configs to handlers.test.js to set wrapWithRetriesConf through env config
kleyow
approved these changes
Dec 12, 2022
|
Test result details can be found here: mojaloop/project#2644 (comment) |
mdebarros
deleted the
fix/#2644-Missing-Error-code-for-the-transfer-in-the-Central-ledger-DB
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(mojaloop/#2644): missing error-code for the transfer in the central-ledger db - mojaloop/project#2644
KafkaHelperto manage connect/disconnect in an effort to resolve the above issue by implementing re-usable helper functions./transfers/handlers.test.jstest-casestest:intto include env configs for TST_RETRY_COUNT, TST_RETRY_TIMEOUT and UV_THREADPOOL_SIZE (increased avaialable threads for NODE-RDKAFKA). This should include consistency for Integration Tests.