feat(mojaloop/#3489): add negative integration tests #975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sri-miriyala
requested review from
mdebarros,
elnyry-sam-k,
vijayg10 and
kleyow
as code owners
|
EC2 Default User seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
kleyow
changed the title
…g' into feat/#3489-negative-integration-tests
kleyow
changed the base branch from
main
to
feature/position-prepare-binnning
kleyow
approved these changes
Sep 26, 2023
vijayg10
approved these changes
Sep 27, 2023
32 tasks
oderayi
pushed a commit
that referenced
this pull request
Nov 9, 2023
* chore: add support for unique transfers and dual currencies in batch * check in for a negative test case * uncommented tests * added test for mixed currencies * updated test for mixed currencies * chore: dep and lint --------- Co-authored-by: Kevin Leyow <kleyow@gmail.com>
kleyow
added a commit
that referenced
this pull request
Dec 5, 2023
* feat: added skeleton and comments for prepare bin implementation * chore: some changes * feat: added new position handler v2 * feat: added some functionality to new position handler v2 * feat: added some todos * feat: changed new handler name * fix: lint * feat: add some changes * fix: lint * chore: added copyright header * feat: added some logic * fix: lint * feat: added unit tests * feat: some improvements * feat: added bin processor logic * fix: lint * feat; refactor * feat: added limit * fix: unit tests * feat: added integration test * feat: refactor * fix: unit tests * fix: integration tests * feat: add position prepare bin logic (#970) * feat: add position prepare bin logic * edit * lint * dep * chore: changes * chore: commet * lint * chore: refactor * chore: unit tests * chore: change * chore: comment * chore: test * chore: more test * chore: test? * chore: remove * chore: rework domain logic * chore: test * fix: position calculation * fix: position change data * fix; prepare domain function * chore: fix --------- Co-authored-by: Vijay <vijaya.guthi@infitx.com> * chore: add tests (#972) * chore: add tests * chore: unit * sleep * chore: clear * chore: test * enum * fix: deadlock in tests --------- Co-authored-by: Vijay <vijaya.guthi@infitx.com> * fix: metrics * fix: some issue with bin processor * feat(mojaloop/#3489): add cached calls for participant currency, update tests (#973) * chore: add tests * chore: unit * sleep * chore: clear * chore: test * enum * feat: add cached calls for participant currency * chore: change * chore: unit * chore: unit * lock * test * fix: unit test --------- Co-authored-by: Vijay <vijaya.guthi@infitx.com> * chore: improve coverage and edit metric and query name (#974) * chore: coverage * lint * chore: coverage * more coverage * chore: test * chore: coverage * chore: metric name * chore: metric name * chore: update query name * chore: remove log * chore(snapshot): 17.3.0-snapshot.0 * fix: test downgrade stream lib * chore(snapshot): 17.3.0-snapshot.1 * fix: notification event action * chore(snapshot): 17.3.0-snapshot.2 * fix: notification event * chore(snapshot): 17.3.0-snapshot.3 * fix: notification messages * chore(snapshot): 17.3.0-snapshot.4 * chore: updated conf * chore: update deps * chore(snapshot): 17.3.0-snapshot.5 * fix(mojaloop/#3529): fix high latency (#981) * fix: upgrade central-services-stream library * chore(snapshot): v17.2.1-snapshot.0 * chore(snapshot): 17.2.1-snapshot.1 * chore(snapshot): 17.2.1-snapshot.2 * chore(release): 17.2.1 [skip ci] * feat(mojaloop/#3489): add negative integration tests (#975) * chore: add support for unique transfers and dual currencies in batch * check in for a negative test case * uncommented tests * added test for mixed currencies * updated test for mixed currencies * chore: dep and lint --------- Co-authored-by: Kevin Leyow <kleyow@gmail.com> * Merge branch main of https://github.com/mojaloop/central-ledger into feature/position-prepare-binning * chore: foreach to for loop * chore: cleanup * Update src/handlers/index.js Co-authored-by: Miguel de Barros <miguel@debarros.me> * chore: added readme doc * fix: lint * fix: unit tests * fix: audit * chore: cleanup * fix(mojaloop/#3533): helm v15.2.0-rc fixes (#982) fix(mojaloop/#3533): helm v15.2.0-rc fixes - mojaloop/project#3533 List of fixes: - fix(mojaloop/#3580): missing toDestination on handling the fspiop source/destiation headers failing match validation on fulfil - regression on #2697 - v17.0.0...v17.2.0#diff-3a2d4aabbde0cd9517dd372f6ae6001ad607d005b5316785c8698fe25160aa92L393 - mojaloop/project#3580 Fixes currently resolve regression failures on these tests: - p2p_money_transfer_put_notifications - payee receives no Notification with ABORTED status after sending invalid FSPIOP-Destination header with transferStatus=COMMITTED, file path: golden_path/bug fixes /Test for Bugfix #2697 - Central-Ledger Fulfil Handler does not correctly invalidate requests with an incorrect-non-existent FSP-ID in the FSPIOP-Destination header.json - p2p_money_transfer_patch_notifications - payee receives PATCH Notification with ABORTED status after sending invalid FSPIOP-Destination header with transferStatus=RESERVED, file path: golden_path/bug fixes/Test for Bugfix #2697 - Central-Ledger Fulfil Handler does not correctly invalidate requests with an incorrect-non-existent FSP-ID in the FSPIOP-Destination header.json * chore(release): 17.3.0 [skip ci] * chore: remove uuid4 (#976) chore: remove uuid4 - Remove uuid4 and use native randomUUID. - Bump some deps are quested by commit hook * chore(release): 17.3.1 [skip ci] * fix(mojaloop/#3615): upgrade dependencies (#985) * chore(release): 17.3.2 [skip ci] * fix: remove unneeded async/await * feat: add validation for participantCurrencyIds / accountIds mapping * chore: remove resolved TODOs * test: Add test coverage * chore: remove whitespaces * fix: fixrebase merge conflict * chore: update dependencies * doc: fix typo * chore(snapshot): 17.4.0-snapshot.0 * chore(snapshot): 17.4.0-snapshot.1 * test: update unit tests * chore(snapshot): 17.4.0-snapshot.2 * fix: route error callback for batch correctly * chore(snapshot): 17.4.0-snapshot.3 * fix(batch): fix error callback message routing. update tests * chore(snapshot): 17.4.0-snapshot.4 * fix(batch): fix message routing / properties for more error cases * chore(snapshot): 17.4.0-snapshot.5 * test: update test coverage * chore(snapshot): 17.4.0-snapshot.6 * fix: route bulk-prepare messages to non-batch prepare handler * chore(snapshot): 17.4.0-snapshot.7 * doc: update comment * chore: update deps. update README for batch. * doc: Address TODO regarding participanLimits query optimization * test: fix local integration testing --------- Co-authored-by: Vijay <vijaya.guthi@infitx.com> Co-authored-by: Aarón Reynoza <aaron.alejandro.reynoza@gmail.com> Co-authored-by: mojaloopci <info@mojaloop.io> Co-authored-by: Sridevi Miriyala <38143240+sri-miriyala@users.noreply.github.com> Co-authored-by: vijayg10 <33152110+vijayg10@users.noreply.github.com> Co-authored-by: Miguel de Barros <miguel@debarros.me> Co-authored-by: Marco Ippolito <marcoippolito54@gmail.com> Co-authored-by: Steven Oderayi <oderayi@gmail.com>
kleyow
added a commit
that referenced
this pull request
Dec 13, 2023
* feat: added skeleton and comments for prepare bin implementation * chore: some changes * feat: added new position handler v2 * feat: added some functionality to new position handler v2 * feat: added some todos * feat: changed new handler name * fix: lint * feat: add some changes * fix: lint * chore: added copyright header * feat: added some logic * fix: lint * feat: added unit tests * feat: some improvements * feat: added bin processor logic * fix: lint * feat; refactor * feat: added limit * fix: unit tests * feat: added integration test * feat: refactor * fix: unit tests * fix: integration tests * feat: add position prepare bin logic (#970) * feat: add position prepare bin logic * edit * lint * dep * chore: changes * chore: commet * lint * chore: refactor * chore: unit tests * chore: change * chore: comment * chore: test * chore: more test * chore: test? * chore: remove * chore: rework domain logic * chore: test * fix: position calculation * fix: position change data * fix; prepare domain function * chore: fix --------- Co-authored-by: Vijay <vijaya.guthi@infitx.com> * chore: add tests (#972) * chore: add tests * chore: unit * sleep * chore: clear * chore: test * enum * fix: deadlock in tests --------- Co-authored-by: Vijay <vijaya.guthi@infitx.com> * fix: metrics * fix: some issue with bin processor * feat(mojaloop/#3489): add cached calls for participant currency, update tests (#973) * chore: add tests * chore: unit * sleep * chore: clear * chore: test * enum * feat: add cached calls for participant currency * chore: change * chore: unit * chore: unit * lock * test * fix: unit test --------- Co-authored-by: Vijay <vijaya.guthi@infitx.com> * chore: improve coverage and edit metric and query name (#974) * chore: coverage * lint * chore: coverage * more coverage * chore: test * chore: coverage * chore: metric name * chore: metric name * chore: update query name * chore: remove log * chore(snapshot): 17.3.0-snapshot.0 * fix: test downgrade stream lib * chore(snapshot): 17.3.0-snapshot.1 * fix: notification event action * chore(snapshot): 17.3.0-snapshot.2 * fix: notification event * chore(snapshot): 17.3.0-snapshot.3 * fix: notification messages * chore(snapshot): 17.3.0-snapshot.4 * chore: updated conf * chore: update deps * chore(snapshot): 17.3.0-snapshot.5 * fix(mojaloop/#3529): fix high latency (#981) * fix: upgrade central-services-stream library * chore(snapshot): v17.2.1-snapshot.0 * chore(snapshot): 17.2.1-snapshot.1 * chore(snapshot): 17.2.1-snapshot.2 * chore(release): 17.2.1 [skip ci] * feat(mojaloop/#3489): add negative integration tests (#975) * chore: add support for unique transfers and dual currencies in batch * check in for a negative test case * uncommented tests * added test for mixed currencies * updated test for mixed currencies * chore: dep and lint --------- Co-authored-by: Kevin Leyow <kleyow@gmail.com> * Merge branch main of https://github.com/mojaloop/central-ledger into feature/position-prepare-binning * chore: foreach to for loop * chore: cleanup * Update src/handlers/index.js Co-authored-by: Miguel de Barros <miguel@debarros.me> * chore: added readme doc * fix: lint * fix: unit tests * fix: audit * chore: cleanup * fix(mojaloop/#3533): helm v15.2.0-rc fixes (#982) fix(mojaloop/#3533): helm v15.2.0-rc fixes - mojaloop/project#3533 List of fixes: - fix(mojaloop/#3580): missing toDestination on handling the fspiop source/destiation headers failing match validation on fulfil - regression on #2697 - v17.0.0...v17.2.0#diff-3a2d4aabbde0cd9517dd372f6ae6001ad607d005b5316785c8698fe25160aa92L393 - mojaloop/project#3580 Fixes currently resolve regression failures on these tests: - p2p_money_transfer_put_notifications - payee receives no Notification with ABORTED status after sending invalid FSPIOP-Destination header with transferStatus=COMMITTED, file path: golden_path/bug fixes /Test for Bugfix #2697 - Central-Ledger Fulfil Handler does not correctly invalidate requests with an incorrect-non-existent FSP-ID in the FSPIOP-Destination header.json - p2p_money_transfer_patch_notifications - payee receives PATCH Notification with ABORTED status after sending invalid FSPIOP-Destination header with transferStatus=RESERVED, file path: golden_path/bug fixes/Test for Bugfix #2697 - Central-Ledger Fulfil Handler does not correctly invalidate requests with an incorrect-non-existent FSP-ID in the FSPIOP-Destination header.json * chore(release): 17.3.0 [skip ci] * chore: remove uuid4 (#976) chore: remove uuid4 - Remove uuid4 and use native randomUUID. - Bump some deps are quested by commit hook * chore(release): 17.3.1 [skip ci] * fix(mojaloop/#3615): upgrade dependencies (#985) * chore(release): 17.3.2 [skip ci] * fix: remove unneeded async/await * feat: add validation for participantCurrencyIds / accountIds mapping * chore: remove resolved TODOs * test: Add test coverage * chore: remove whitespaces * fix: fixrebase merge conflict * chore: update dependencies * doc: fix typo * chore(snapshot): 17.4.0-snapshot.0 * chore(snapshot): 17.4.0-snapshot.1 * test: update unit tests * chore(snapshot): 17.4.0-snapshot.2 * fix: route error callback for batch correctly * chore(snapshot): 17.4.0-snapshot.3 * fix(batch): fix error callback message routing. update tests * chore(snapshot): 17.4.0-snapshot.4 * fix(batch): fix message routing / properties for more error cases * chore(snapshot): 17.4.0-snapshot.5 * test: update test coverage * chore(snapshot): 17.4.0-snapshot.6 * fix: route bulk-prepare messages to non-batch prepare handler * chore(snapshot): 17.4.0-snapshot.7 * doc: update comment * chore: update deps. update README for batch. * doc: Address TODO regarding participanLimits query optimization * stash * chore: domain * chore: test * test * chore: update bin processor tests * chore: coverage * log * chore: update * chore: up retries * chore: test * ci * test * install * test * test * test * script * chore: fix order * time * test * time * time * state * time * chore: check transfer state * test * lint * chore: await * address comments * chore: dep * chore: address comments * coverage * chore(snapshot): 17.5.0-snapshot.0 * remove --------- Co-authored-by: Vijay <vijaya.guthi@infitx.com> Co-authored-by: Aarón Reynoza <aaron.alejandro.reynoza@gmail.com> Co-authored-by: mojaloopci <info@mojaloop.io> Co-authored-by: Sridevi Miriyala <38143240+sri-miriyala@users.noreply.github.com> Co-authored-by: vijayg10 <33152110+vijayg10@users.noreply.github.com> Co-authored-by: Miguel de Barros <miguel@debarros.me> Co-authored-by: Marco Ippolito <marcoippolito54@gmail.com> Co-authored-by: Steven Oderayi <oderayi@gmail.com>
kleyow
added a commit
that referenced
this pull request
Dec 20, 2023
* feat: added skeleton and comments for prepare bin implementation * chore: some changes * feat: added new position handler v2 * feat: added some functionality to new position handler v2 * feat: added some todos * feat: changed new handler name * fix: lint * feat: add some changes * fix: lint * chore: added copyright header * feat: added some logic * fix: lint * feat: added unit tests * feat: some improvements * feat: added bin processor logic * fix: lint * feat; refactor * feat: added limit * fix: unit tests * feat: added integration test * feat: refactor * fix: unit tests * fix: integration tests * feat: add position prepare bin logic (#970) * feat: add position prepare bin logic * edit * lint * dep * chore: changes * chore: commet * lint * chore: refactor * chore: unit tests * chore: change * chore: comment * chore: test * chore: more test * chore: test? * chore: remove * chore: rework domain logic * chore: test * fix: position calculation * fix: position change data * fix; prepare domain function * chore: fix --------- Co-authored-by: Vijay <vijaya.guthi@infitx.com> * chore: add tests (#972) * chore: add tests * chore: unit * sleep * chore: clear * chore: test * enum * fix: deadlock in tests --------- Co-authored-by: Vijay <vijaya.guthi@infitx.com> * fix: metrics * fix: some issue with bin processor * feat(mojaloop/#3489): add cached calls for participant currency, update tests (#973) * chore: add tests * chore: unit * sleep * chore: clear * chore: test * enum * feat: add cached calls for participant currency * chore: change * chore: unit * chore: unit * lock * test * fix: unit test --------- Co-authored-by: Vijay <vijaya.guthi@infitx.com> * chore: improve coverage and edit metric and query name (#974) * chore: coverage * lint * chore: coverage * more coverage * chore: test * chore: coverage * chore: metric name * chore: metric name * chore: update query name * chore: remove log * chore(snapshot): 17.3.0-snapshot.0 * fix: test downgrade stream lib * chore(snapshot): 17.3.0-snapshot.1 * fix: notification event action * chore(snapshot): 17.3.0-snapshot.2 * fix: notification event * chore(snapshot): 17.3.0-snapshot.3 * fix: notification messages * chore(snapshot): 17.3.0-snapshot.4 * chore: updated conf * chore: update deps * chore(snapshot): 17.3.0-snapshot.5 * fix(mojaloop/#3529): fix high latency (#981) * fix: upgrade central-services-stream library * chore(snapshot): v17.2.1-snapshot.0 * chore(snapshot): 17.2.1-snapshot.1 * chore(snapshot): 17.2.1-snapshot.2 * chore(release): 17.2.1 [skip ci] * feat(mojaloop/#3489): add negative integration tests (#975) * chore: add support for unique transfers and dual currencies in batch * check in for a negative test case * uncommented tests * added test for mixed currencies * updated test for mixed currencies * chore: dep and lint --------- Co-authored-by: Kevin Leyow <kleyow@gmail.com> * Merge branch main of https://github.com/mojaloop/central-ledger into feature/position-prepare-binning * chore: foreach to for loop * chore: cleanup * Update src/handlers/index.js Co-authored-by: Miguel de Barros <miguel@debarros.me> * chore: added readme doc * fix: lint * fix: unit tests * fix: audit * chore: cleanup * fix(mojaloop/#3533): helm v15.2.0-rc fixes (#982) fix(mojaloop/#3533): helm v15.2.0-rc fixes - mojaloop/project#3533 List of fixes: - fix(mojaloop/#3580): missing toDestination on handling the fspiop source/destiation headers failing match validation on fulfil - regression on #2697 - v17.0.0...v17.2.0#diff-3a2d4aabbde0cd9517dd372f6ae6001ad607d005b5316785c8698fe25160aa92L393 - mojaloop/project#3580 Fixes currently resolve regression failures on these tests: - p2p_money_transfer_put_notifications - payee receives no Notification with ABORTED status after sending invalid FSPIOP-Destination header with transferStatus=COMMITTED, file path: golden_path/bug fixes /Test for Bugfix #2697 - Central-Ledger Fulfil Handler does not correctly invalidate requests with an incorrect-non-existent FSP-ID in the FSPIOP-Destination header.json - p2p_money_transfer_patch_notifications - payee receives PATCH Notification with ABORTED status after sending invalid FSPIOP-Destination header with transferStatus=RESERVED, file path: golden_path/bug fixes/Test for Bugfix #2697 - Central-Ledger Fulfil Handler does not correctly invalidate requests with an incorrect-non-existent FSP-ID in the FSPIOP-Destination header.json * chore(release): 17.3.0 [skip ci] * chore: remove uuid4 (#976) chore: remove uuid4 - Remove uuid4 and use native randomUUID. - Bump some deps are quested by commit hook * chore(release): 17.3.1 [skip ci] * fix(mojaloop/#3615): upgrade dependencies (#985) * chore(release): 17.3.2 [skip ci] * fix: remove unneeded async/await * feat: add validation for participantCurrencyIds / accountIds mapping * chore: remove resolved TODOs * test: Add test coverage * chore: remove whitespaces * fix: fixrebase merge conflict * chore: update dependencies * doc: fix typo * chore(snapshot): 17.4.0-snapshot.0 * chore(snapshot): 17.4.0-snapshot.1 * test: update unit tests * chore(snapshot): 17.4.0-snapshot.2 * fix: route error callback for batch correctly * chore(snapshot): 17.4.0-snapshot.3 * fix(batch): fix error callback message routing. update tests * chore(snapshot): 17.4.0-snapshot.4 * fix(batch): fix message routing / properties for more error cases * chore(snapshot): 17.4.0-snapshot.5 * test: update test coverage * chore(snapshot): 17.4.0-snapshot.6 * fix: route bulk-prepare messages to non-batch prepare handler * chore(snapshot): 17.4.0-snapshot.7 * doc: update comment * chore: update deps. update README for batch. * doc: Address TODO regarding participanLimits query optimization * stash * chore: domain * chore: test * test * chore: update bin processor tests * chore: coverage * log * chore: update * chore: up retries * chore: test * ci * test * install * test * test * test * script * chore: fix order * time * test * time * time * state * time * chore: check transfer state * test * lint * chore: await * address comments * chore: dep * chore: address comments * coverage * chore(snapshot): 17.5.0-snapshot.0 * feat: add reserve functionality * int test * remove * name * dep:check --------- Co-authored-by: Vijay <vijaya.guthi@infitx.com> Co-authored-by: Aarón Reynoza <aaron.alejandro.reynoza@gmail.com> Co-authored-by: mojaloopci <info@mojaloop.io> Co-authored-by: Sridevi Miriyala <38143240+sri-miriyala@users.noreply.github.com> Co-authored-by: vijayg10 <33152110+vijayg10@users.noreply.github.com> Co-authored-by: Miguel de Barros <miguel@debarros.me> Co-authored-by: Marco Ippolito <marcoippolito54@gmail.com> Co-authored-by: Steven Oderayi <oderayi@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(mojaloop/#3489): add negative integration tests - mojaloop/project#3489