Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue934-FixSetEnvVarRCAsBooleanInsteadOfString-UpdateDepsPackageVer #251

Conversation

gibaros
Copy link
Contributor

@gibaros gibaros commented Nov 4, 2019

Issue934 - Fix set env variable RC as Boolean instead of String and update dependencies and package ver

Copy link
Member

@mdebarros mdebarros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

I believe you're missing the dependency in the package.json?

I.e. npm install parse-strings-in-object

I am not sure how the CI/CD has passed since this is missing?

Copy link
Contributor

@rmothilal rmothilal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you vulnerability check is failing and you need to update you branch to align with master

Copy link
Contributor

@rmothilal rmothilal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

happy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants