Bugfix/#1381 notification bug #436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oderayi
requested review from
yosheeck,
shashi165,
aenns,
vgenev,
elnyry-sam-k,
mdebarros and
rmothilal
3 tasks
elnyry-sam-k
reviewed
Jun 8, 2020
elnyry-sam-k
reviewed
Jun 9, 2020
shashi165
added a commit
to shashi165/ml-api-adapter
that referenced
this pull request
Jun 10, 2020
Bugfix/#1381 notification bug (mojaloop#436)
eoln
added a commit
that referenced
this pull request
Jul 1, 2020
* Hotfix/get transfer jws (#434) * fixed JWS issue with GET transfers * fix python circleci issue * fix python circleci issue Co-authored-by: Shashi <shashikant.hirugade@modusbox.com> * Changes for bug 1408 (#435) * Bugfix/#1381 notification bug (#436) * Fix notification bug * Update unit tests * Update version * Add timeout-reserved notification handler * Update deps & version to 10.4.0 * Update packages. Remove unnecessary code * Remove payee notification for timeout-received. Update dependencies * Hotfix - jws not signed for fulfil duplicate notification (#437) * fulfil dup not signed fix * cleanup Co-authored-by: Shashi <shashikant.hirugade@modusbox.com> * Fix audit vulnerabilities (#440) * fulfil dup not signed fix * cleanup * resolve audit failures Co-authored-by: Shashi <shashikant.hirugade@modusbox.com> * Fix the circle ci python issue (#441) * fulfil dup not signed fix * cleanup * resolve audit failures * fix circle ci config * fix circle ci config * fix circle ci config Co-authored-by: Shashi <shashikant.hirugade@modusbox.com> * Added a condition to check from and to fspids while sending notification to payee (#442) * Changes for issue: mojaloop/project#1378 (#443) * Feature/#1334 patch request notif (#444) * updated central-services-shared and event-sdk versions to support custom tags in the tracestate header * added tests fixed condition for reserve functionality that was braking the integration tests. added unit tests Co-authored-by: Valentin <valentin.genev@modusbox.com> * Feature/#1334 patch request notif 2 (#445) * updated central-services-shared and event-sdk versions to support custom tags in the tracestate header * added tests * fixed condition for reserve functionality that was braking the integration tests. added unit tests * added headerValidation plugin * fixed function tests Co-authored-by: Valentin <valentin.genev@modusbox.com> Co-authored-by: shashi165 <33355509+shashi165@users.noreply.github.com> Co-authored-by: Shashi <shashikant.hirugade@modusbox.com> Co-authored-by: Adrian Enns <ennsak@gmail.com> Co-authored-by: Steven Oderayi <oderayi@gmail.com> Co-authored-by: vijayg10 <33152110+vijayg10@users.noreply.github.com> Co-authored-by: Valentin Genev <vgenev@gmail.com> Co-authored-by: Valentin <valentin.genev@modusbox.com>
kleyow
pushed a commit
to kleyow/ml-api-adapter
that referenced
this pull request
Sep 3, 2020
* Hotfix/get transfer jws (mojaloop#434) * fixed JWS issue with GET transfers * fix python circleci issue * fix python circleci issue Co-authored-by: Shashi <shashikant.hirugade@modusbox.com> * Changes for bug 1408 (mojaloop#435) * Bugfix/#1381 notification bug (mojaloop#436) * Fix notification bug * Update unit tests * Update version * Add timeout-reserved notification handler * Update deps & version to 10.4.0 * Update packages. Remove unnecessary code * Remove payee notification for timeout-received. Update dependencies * Hotfix - jws not signed for fulfil duplicate notification (mojaloop#437) * fulfil dup not signed fix * cleanup Co-authored-by: Shashi <shashikant.hirugade@modusbox.com> * Fix audit vulnerabilities (mojaloop#440) * fulfil dup not signed fix * cleanup * resolve audit failures Co-authored-by: Shashi <shashikant.hirugade@modusbox.com> * Fix the circle ci python issue (mojaloop#441) * fulfil dup not signed fix * cleanup * resolve audit failures * fix circle ci config * fix circle ci config * fix circle ci config Co-authored-by: Shashi <shashikant.hirugade@modusbox.com> * Added a condition to check from and to fspids while sending notification to payee (mojaloop#442) * Changes for issue: mojaloop/project#1378 (mojaloop#443) * Feature/#1334 patch request notif (mojaloop#444) * updated central-services-shared and event-sdk versions to support custom tags in the tracestate header * added tests fixed condition for reserve functionality that was braking the integration tests. added unit tests Co-authored-by: Valentin <valentin.genev@modusbox.com> * Feature/#1334 patch request notif 2 (mojaloop#445) * updated central-services-shared and event-sdk versions to support custom tags in the tracestate header * added tests * fixed condition for reserve functionality that was braking the integration tests. added unit tests * added headerValidation plugin * fixed function tests Co-authored-by: Valentin <valentin.genev@modusbox.com> Co-authored-by: shashi165 <33355509+shashi165@users.noreply.github.com> Co-authored-by: Shashi <shashikant.hirugade@modusbox.com> Co-authored-by: Adrian Enns <ennsak@gmail.com> Co-authored-by: Steven Oderayi <oderayi@gmail.com> Co-authored-by: vijayg10 <33152110+vijayg10@users.noreply.github.com> Co-authored-by: Valentin Genev <vgenev@gmail.com> Co-authored-by: Valentin <valentin.genev@modusbox.com>
kleyow
added a commit
that referenced
this pull request
Sep 4, 2020
* Hotfix/get transfer jws (#434) * fixed JWS issue with GET transfers * fix python circleci issue * fix python circleci issue Co-authored-by: Shashi <shashikant.hirugade@modusbox.com> * Changes for bug 1408 (#435) * Bugfix/#1381 notification bug (#436) * Fix notification bug * Update unit tests * Update version * Add timeout-reserved notification handler * Update deps & version to 10.4.0 * Update packages. Remove unnecessary code * Remove payee notification for timeout-received. Update dependencies * Hotfix - jws not signed for fulfil duplicate notification (#437) * fulfil dup not signed fix * cleanup Co-authored-by: Shashi <shashikant.hirugade@modusbox.com> * Fix audit vulnerabilities (#440) * fulfil dup not signed fix * cleanup * resolve audit failures Co-authored-by: Shashi <shashikant.hirugade@modusbox.com> * Fix the circle ci python issue (#441) * fulfil dup not signed fix * cleanup * resolve audit failures * fix circle ci config * fix circle ci config * fix circle ci config Co-authored-by: Shashi <shashikant.hirugade@modusbox.com> * Added a condition to check from and to fspids while sending notification to payee (#442) * Changes for issue: mojaloop/project#1378 (#443) * Feature/#1334 patch request notif (#444) * updated central-services-shared and event-sdk versions to support custom tags in the tracestate header * added tests fixed condition for reserve functionality that was braking the integration tests. added unit tests Co-authored-by: Valentin <valentin.genev@modusbox.com> * Feature/#1334 patch request notif 2 (#445) * updated central-services-shared and event-sdk versions to support custom tags in the tracestate header * added tests * fixed condition for reserve functionality that was braking the integration tests. added unit tests * added headerValidation plugin * fixed function tests Co-authored-by: Valentin <valentin.genev@modusbox.com> * Upgraded central-services-shared library to 10.5.3, bump version (#447) * Upgraded central-services-shared library to 10.5.3, bump version * Ignore vulnerability for a week Co-authored-by: Claudio <claudio.viola@happycog.com> * Hotfix: Fix "latest" release in Docker Hub (#451) * Bump version, update dependencies and resolve audit issues * Remove caret from library versions * Hotfix: Reset package-lock.json to fix AJV vulnerability (#452) * Reset package-lock.json to fix ajv vulnerability * Bump version * Added updated Mojaloop license (#357) Co-authored-by: Sam <elnyry@users.noreply.github.com> * Feature/fix timeout notification issue (#453) * Fix the timeout notification headers * update the npm versions * Fix/#1652 currency validation (#456) * changed currency validator with custom one * changed version Co-authored-by: Valentin <valentin.genev@modusbox.com> * Fix/#1652 ver update (#457) * changed version Co-authored-by: Valentin <valentin.genev@modusbox.com> Co-authored-by: Sam <10507686+elnyry-sam-k@users.noreply.github.com> * Edited CI to build PISP docker image. (#438) * Edited CI to build PISP docker image. * Addressed comments. * Updated ci to python3 and ignored vulnerabilities. (#439) * Update pisp/master (#446) * Hotfix/get transfer jws (#434) * fixed JWS issue with GET transfers * fix python circleci issue * fix python circleci issue Co-authored-by: Shashi <shashikant.hirugade@modusbox.com> * Changes for bug 1408 (#435) * Bugfix/#1381 notification bug (#436) * Fix notification bug * Update unit tests * Update version * Add timeout-reserved notification handler * Update deps & version to 10.4.0 * Update packages. Remove unnecessary code * Remove payee notification for timeout-received. Update dependencies * Hotfix - jws not signed for fulfil duplicate notification (#437) * fulfil dup not signed fix * cleanup Co-authored-by: Shashi <shashikant.hirugade@modusbox.com> * Fix audit vulnerabilities (#440) * fulfil dup not signed fix * cleanup * resolve audit failures Co-authored-by: Shashi <shashikant.hirugade@modusbox.com> * Fix the circle ci python issue (#441) * fulfil dup not signed fix * cleanup * resolve audit failures * fix circle ci config * fix circle ci config * fix circle ci config Co-authored-by: Shashi <shashikant.hirugade@modusbox.com> * Added a condition to check from and to fspids while sending notification to payee (#442) * Changes for issue: mojaloop/project#1378 (#443) * Feature/#1334 patch request notif (#444) * updated central-services-shared and event-sdk versions to support custom tags in the tracestate header * added tests fixed condition for reserve functionality that was braking the integration tests. added unit tests Co-authored-by: Valentin <valentin.genev@modusbox.com> * Feature/#1334 patch request notif 2 (#445) * updated central-services-shared and event-sdk versions to support custom tags in the tracestate header * added tests * fixed condition for reserve functionality that was braking the integration tests. added unit tests * added headerValidation plugin * fixed function tests Co-authored-by: Valentin <valentin.genev@modusbox.com> Co-authored-by: shashi165 <33355509+shashi165@users.noreply.github.com> Co-authored-by: Shashi <shashikant.hirugade@modusbox.com> Co-authored-by: Adrian Enns <ennsak@gmail.com> Co-authored-by: Steven Oderayi <oderayi@gmail.com> Co-authored-by: vijayg10 <33152110+vijayg10@users.noreply.github.com> Co-authored-by: Valentin Genev <vgenev@gmail.com> Co-authored-by: Valentin <valentin.genev@modusbox.com> * chore: remove rebase error Co-authored-by: shashi165 <33355509+shashi165@users.noreply.github.com> Co-authored-by: Shashi <shashikant.hirugade@modusbox.com> Co-authored-by: Adrian Enns <ennsak@gmail.com> Co-authored-by: Steven Oderayi <oderayi@gmail.com> Co-authored-by: vijayg10 <33152110+vijayg10@users.noreply.github.com> Co-authored-by: Valentin Genev <vgenev@gmail.com> Co-authored-by: Valentin <valentin.genev@modusbox.com> Co-authored-by: Claudio Viola <claudio-viola@users.noreply.github.com> Co-authored-by: Claudio <claudio.viola@happycog.com> Co-authored-by: Lewis Daly <lewis@vesselstech.com> Co-authored-by: Sam <elnyry@users.noreply.github.com> Co-authored-by: Sam <10507686+elnyry-sam-k@users.noreply.github.com> Co-authored-by: eoln <2881004+eoln@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SEND_TRANSFER_CONFIRMATION_TO_PAYEEconfiguration.