Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changed the joi validation to use regex instead of hard-coded values #67

Merged
merged 1 commit into from
Oct 18, 2018
Merged

changed the joi validation to use regex instead of hard-coded values #67

merged 1 commit into from
Oct 18, 2018

Conversation

shashi165
Copy link
Contributor

Changes for Bug #516

Removed the hard-coded values for 'accept' and 'content-type' headers validation. Now it will use a regex

Tests

=============================== Coverage summary ===============================
Statements   : 100% ( 522/522 )
Branches     : 100% ( 103/103 )
Functions    : 100% ( 55/55 )
Lines        : 100% ( 522/522 )
================================================================================

1..152
# tests 152
# pass  152

# ok

@shashi165 shashi165 self-assigned this Oct 18, 2018
@ksatya77
Copy link
Contributor

LGTM

@shashi165 shashi165 merged commit 2cd7fec into mojaloop:develop Oct 18, 2018
@rasputtintin rasputtintin mentioned this pull request May 20, 2022
Open
@rasputtintin rasputtintin mentioned this pull request Aug 24, 2023
Open
This was referenced Nov 28, 2023
Open
Open
@rasputtintin rasputtintin mentioned this pull request Dec 19, 2023
Open
@rasputtintin rasputtintin mentioned this pull request Mar 22, 2024
Open
@rasputtintin rasputtintin mentioned this pull request Apr 15, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ksatya77 ksatya77 ksatya77 approved these changes

@elnyry-sam-k elnyry-sam-k Awaiting requested review from elnyry-sam-k

@rmothilal rmothilal Awaiting requested review from rmothilal

Assignees

@shashi165 shashi165

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shashi165 @ksatya77