Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mojaloop/#3412): extend callback handler to mock oracle and central admin apis #12

Conversation

vijayg10
Copy link
Contributor

feat(mojaloop/#3412): extend callback handler to mock oracle and central admin apis - mojaloop/project#3412

@vijayg10 vijayg10 changed the base branch from master to feat/performance-maintenance-characterisation-als July 20, 2023 13:38
@kleyow kleyow force-pushed the feat/#3412-mock-handlers branch from 65965d2 to 4e95b55 Compare July 21, 2023 02:18
@vijayg10 vijayg10 requested a review from mdebarros July 21, 2023 13:03
Copy link
Member

@mdebarros mdebarros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See some of my comments

vijayg10 and others added 6 commits July 21, 2023 18:46
Co-authored-by: Miguel de Barros <miguel@debarros.me>
- made docker-compose-perf-als generic, i.e. removed the als suffix
- moved callback-handler-svc to docker-compose-perf instead of monitoring, so that we can run the load-tests without the monitoring stack if desired
- moved env vars for callback-handler-svc to main .env, and updated docker compose to import .env
Copy link
Member

@mdebarros mdebarros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@mdebarros mdebarros merged commit d89a1ff into feat/performance-maintenance-characterisation-als Jul 21, 2023
@vijayg10 vijayg10 deleted the feat/#3412-mock-handlers branch July 31, 2023 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants