Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mojaloop/3032): configurable param option fixes #148

Merged
merged 8 commits into from
Dec 5, 2022

Conversation

vijayg10
Copy link
Collaborator

@vijayg10 vijayg10 commented Dec 2, 2022

fix(mojaloop/3032): configurable param option fixes:

  • When an element in the request is an array, that should be properly populated in the "Configurable Param" option
  • When a property in the request body is selected in the Configurable Param dialogue, we are not able to select a different one immediately when we try to change our selection
  • When we select "Previous Request" from "Configurable Param" option, it should get the openAPIDefinition of the selected request. Currently its trying to get the path based on the current openAPI definition.

src/index.js Outdated Show resolved Hide resolved
Copy link
Contributor

@kleyow kleyow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vijayg10 vijayg10 merged commit 6f63764 into master Dec 5, 2022
@vijayg10 vijayg10 deleted the fix/configurable-param branch December 5, 2022 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants