Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests to cater for updated regex for Accented & other unicode Characters #1452

Closed
14 tasks done
rmothilal opened this issue Jun 25, 2020 · 1 comment
Closed
14 tasks done

Tests to cater for updated regex for Accented & other unicode Characters #1452

rmothilal opened this issue Jun 25, 2020 · 1 comment
Assignees
@elnyry-sam-k @vijayg10
Labels
oss-core This is an issue - story or epic related to a feature on a Mojaloop core service or related to it story
Milestone
Sprint 15.3

Comments

@rmothilal
Copy link

rmothilal commented Jun 25, 2020 •
edited by elnyry-sam-k
Loading

Goal:

As an adopter of Mojaloop

I want to have TTK tests (new or existed ones updated) for APIs that are using OpenAPI Backend

so that we can have thorough regression tests and ensure that Accent characters and multiple language scripts are supported.

Tasks:

  • Enhance TTK to support new regex for names in spec files
  • Update regex in TTK v1.1 and v1.0 to use the updated interpretation
    pattern: '^(?!\s*$)[\p{L}\p{gc=Mark}\p{digit}\p{gc=Connector_Punctuation}\p{Join_Control} .,''-]{1,128}$'
  • TTK tests
    • ALS, Quotes tests and ENV variables for
      • Unicode characters - accented
      • Unicode characters - Burmese

Acceptance Criteria:

  • TTK supports new regular expression for names that supports unicode characters (and scripts)
  • Regression Tests for accented and Burmese character. pass
  • Code Style & Coverage meets standards
  • Tests covering Regular expressions and unicode characters are available for
    • Unicode characters - accented
    • Unicode characters - Burmese

Pull Requests:

Follow-up:

  • N/A

Dependencies:

  • N/A

Accountability:
@rmothilal rmothilal added this to the Sprint 10.5 milestone Jun 25, 2020
@rmothilal rmothilal self-assigned this Jun 25, 2020
@elnyry-sam-k elnyry-sam-k removed this from the Sprint 10.5 milestone Jul 2, 2020
@elnyry-sam-k elnyry-sam-k added the oss-core This is an issue - story or epic related to a feature on a Mojaloop core service or related to it label Jul 15, 2020
@elnyry-sam-k elnyry-sam-k added the technical-debt Label to mark issues/stories as a technical debt item to be resolved in future label Nov 3, 2020
@elnyry-sam-k elnyry-sam-k added oss-ttk Related to the Mojaloop testing toolkit and removed technical-debt Label to mark issues/stories as a technical debt item to be resolved in future labels Aug 17, 2021
@elnyry-sam-k elnyry-sam-k added this to the Sprint 15.2 milestone Aug 17, 2021
@elnyry-sam-k elnyry-sam-k changed the title Add tests to cater for updated Openapi-Backend APIs and Accented Characters Tests to cater for updated Openapi-Backend APIs and Accented Characters Aug 17, 2021
@elnyry-sam-k elnyry-sam-k removed the oss-ttk Related to the Mojaloop testing toolkit label Aug 27, 2021
@elnyry-sam-k elnyry-sam-k modified the milestones: Sprint 15.2, Sprint 15.3 Aug 30, 2021
@elnyry-sam-k elnyry-sam-k self-assigned this Aug 31, 2021
@elnyry-sam-k elnyry-sam-k changed the title Tests to cater for updated Openapi-Backend APIs and Accented Characters Tests to cater for updated regex for Accented & other unicode Characters Aug 31, 2021
elnyry-sam-k added a commit to elnyry-sam-k/testing-toolkit-test-cases that referenced this issue Sep 10, 2021
@elnyry-sam-k
P2P test with Burmese characters as part of issue mojaloop/project#1452
2e87eec
@elnyry-sam-k
Copy link
Member

Released with https://github.com/mojaloop/testing-toolkit-test-cases/releases/tag/v13.0.2

mdebarros added a commit to mojaloop/helm that referenced this issue Sep 13, 2021
@mdebarros
updated v13.0.2 release notes with
c48505e 
- Feature notes for mojaloop/project#1452
- Bug fix placeholder (which is pending a fix) for mojaloop/project#2474
mdebarros added a commit to mojaloop/helm that referenced this issue Sep 17, 2021
@mdebarros @vijayg10
fix(mojaloop/#2382): release v13.0.2 (#448)
bb0d997 
* fix: release/v13.0.1 (#445)

- Upgraded Central-Settlement from v13.4.0 to v13.4.1, fixes errors when `sidecar.enabled=true` issue (mojaloop/project#2368).
- Added missing `default-sidecar.json` to Central-Settlement Template chart
- Added a `.changelog` folder with release notes for v13.0.0 and v13.0.1
- Added additional "commented" values to Testing Toolkit to improve the ease of configurability
-  fixed issue (mojaloop/project#2359) when running TTK deployments in "hosted" mode.
   - Updated Testing Toolkit v13.2.1 to v13.2.2
   - Updated structure to Testing Toolkit (TTK) Backend value for `CONNECTION_MANAGER_AUTH_ENABLED` to `CONNECTION_MANAGER.AUTH_ENABLED`.

chore: release v13.0.2

- Added release notes for v13.0.2
- Fixed typos in release notes v13.0.0, v13.0.1
- Upgraded Account-lookup-service from v11.7.0 to v11.7.2 -> fix for mojaloop/project#2358
- Bump to Account-lookup-service helm chart
- Bump to Mojaloop helm chart

chore: release v13.0.2

- Added release notes for v13.0.2
- Fixed typos in release notes v13.0.0, v13.0.1
- Upgraded Account-lookup-service from v11.7.0 to v11.7.2 -> fix for mojaloop/project#2358
- Bump to Account-lookup-service helm chart
- Bump to Mojaloop helm chart

* Updated quoting-service from 12.0.6 to 12.0.7

- Bumped Mojaloop helm charts
- Bumped Quoting-service helm charts
- Upgraded quoting-service from 12.0.6 to 12.0.7
- Updated release notes for v13.0.2

* Bump to mojaloop

* Updated account-lookup-service from v11.7.2 to v11.7.3

* Updated simulator from v11.0.2 to v11.0.3

* Updated account-lookup-service from v11.7.3 to v11.7.4

* Updated 13.0.2 release notes

- Added 2nd PR to fix issue 2374

* Fix typo in release notes

* eventstreamprocessor log_level is now info by default

* fix(mojaloop/#2405): helm release v13.0.x upgrades fail after several iterations

Fixes for mojaloop/project#2405:
- Added duplicate protection for set env vars for the mojaloop-simulator deployment descriptor.
- Uncommented statically configured env vars for the mojaloop-simulator in the values.yaml and removed them from the deployment descriptor.
- Removed breaking mojaloop-simulator configs from the mojaloop/values.yaml. They can still be configured if required, but rather hide configs that should be avoided.
- Parch version bump to mojaloop-simulators Helm chart

* Updated changelog

* Fixed some comments

* - upgraded sdk-scheme-adapter

- from  v11.17.1 -> **v11.18.7**
- minor bump to mojaloop-simulator
- updated v13.0.2 release notes
- Changed default value of liveliness and readiness probes enablement to true on quoting-service

* upgraded quoting-service to v12.0.9

- updated docker images
- updated release notes

* Updated release notes with known issues

* bump to quoting-service to v12.0.10

* added missing allow.auto.create.topics for kafka consumer configs

* updated v13.0.2 release notes for previous commit

* Feature/upgrade ttk (#449)

* Upgraded TTK app versions and bumped up the chart version

* Added release notes

* Upgraded mojaloop-testing-toolkit

- Backend from v13.4.0 to v13.5.2
- UI from v13.4.0 to v13.5.0

* chore: bumped account-lookup-service

- maintenance update on dependencies, no functional changes or bug fixes included in this version bump

* Updates to account-lookup-service

- Bump ALS from v11.7.5 to 11.7.7

* Updated MySQL Configuration to support utf8 encoding

- mojaloop/project#2471

* Added env vars for accented/burmese characters to TTK env config

* updated v13.0.2 release notes with

- Feature notes for mojaloop/project#1452
- Bug fix placeholder (which is pending a fix) for mojaloop/project#2474

* Updated typo

* updated transaction-request-service

- upgraded image from v11.1.5 to v11.1.6
- minor bump to chart version

* bump to transaction-request-service

- updated image to v11.1.7 due to updated readme

* updated ttk frontend

- upgraded v13.5.0 to v13.5.2

* bump to account-lookup and quoting-service chart versions

* chore: maintenance updates

- added initContainer to sdk-scheme-adapter
- added mysql config for utf8mb4 character sets

* chore: lots of updates

- upgraded sdk-scheme-adapter from v11.18.7 t v11.17.8
- upgraded central-ledger components from v13.12.1 to v13.14.0
- chart bumps to reflect the upgrades above
- added checksum annotation on TTK backend to ensure updates restart pods in the statefulset when changes are made
- updated release notes for v13.0.2

* updated release notes

* chore: maintenance update

- added checksum annotations to all supported charts
- patch bump to all charts (where applicable) to reflect the above change
- updated release notes

* updates to release notes

* updated release notes

* updated release notes

* updated release notes

* updated release notes

* updated release notes

* updated release notes

* feat: parameteriized sim names in ttk env (#450)

* Added parameters logic for extra environments property

* Introduced the parameters for simulator names in ml-testing-toolkit values in mojaloop

* Added parameters logic to TTK CLI chart

* Added parameters to TTK CLI values in the mojaloop values file

* Fixed the issue with TTK CLI chart

* Removed unneccessary anchors

* updating release notes

Co-authored-by: vijayg10 <33152110+vijayg10@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@elnyry-sam-k elnyry-sam-k

@vijayg10 vijayg10

Labels
oss-core This is an issue - story or epic related to a feature on a Mojaloop core service or related to it story
Projects
None yet
Milestone
Sprint 15.3
Development

No branches or pull requests
3 participants
@elnyry-sam-k @rmothilal @vijayg10