Incorrect error behaviour on transfer fulfilment with future timestamp

[bushjames]

Summary:
When the switch receives a transfer fulfilment message from a payee DFSP, if the completed timestamp property is further in the future, from the switch clock perspective, than the configured tolerance, the switch generates an incorrect error notification.

The notification should take the form of a PUT /transfers/{id}/error call, but instead it is made as a PUT /transfers/{id} call with "ABORTED" as the transferState.

Severity:
High

Priority:
Medium

Expected Behavior
When the switch receives a transfer fulfilment message from a payee DFSP, if the completed timestamp property is further in the future, from the switch clock perspective, than the configured tolerance, the switch generates an incorrect error notification.

The notification should take the form of a PUT /transfers/{id}/error call, but instead it is made as a PUT /transfers/{id} call with "ABORTED" as the transferState.

Steps to Reproduce

1. Use a simulator as Payee DFSP with its internal clock set ahead of the switch by some number of seconds greater than the switch tolerance level
2. Send the simulated Payee DFSP a transfer that is otherwise valid.
   3.Note the notifications generated by the switch upon fulfilment from the simulated Payee DFSP.

Specifications

• Component (if known):
• Version: 10.1.0
• Platform:
• Subsystem: Transfers
• Type of testing: End-to-end
• Bug found/raised by: Mowali (Mahadev/James)

Notes:

• Severity when opened: High
• Priority when opened: Medium

Tasks:

• Implement error callback when timestamp error occurs ( add error code - 3300 or 3303 ) [@oderayi]
• Unit Test [@oderayi]
• Update Mojasim collection, if need be [@oderayi]
• Regression test using postman Mojasim collection [@oderayi]
• Release [@oderayi]
• Validate release in DEV2 [@oderayi]

Pull Requests

• #1708: Fix error callback for expired transfers central-ledger#785
• #1708: Unit tests for timeout callback fix central-ledger#786
• #1708: Add test for Payee responding with future timestamp in transfer fulfillment postman#177

[elnyry-sam-k]

Thanks @amarmodus for reproducing the bug and confirming..

[ramakrishnan-sankar]

blocked due to node failure in k8s cluster in AWS.