Inconsistent Transfer Timeout error messages being sent by Central-Ledger

[mdebarros]

Summary:

Central-ledger is providing inconsistent Timeout error code/message results in the feature-tests/transfer_negative_scenarios/payee_invalid_timestamp tests from the Golden_Path_Mojaloop Postman.

Severity:
Medium

Priority:
Medium

Expected Behavior
All timeout-errors should be consisant with TRANSFER_EXPIRED: { code: '3303', message: 'Transfer expired'} (https://github.com/mojaloop/central-ledger/blob/master/src/handlers/timeouts/handler.js#L71).

Check Transfer status on Payerfsp - ErroInformation should always receive the same error Transfer expired regardless of whether it's validating the Timeout-Callback or the Get-Request-Callback.

Steps to Reproduce

1. Run the feature-tests/transfer_negative_scenarios/payee_invalid_timestamp tests from the Golden_Path_Mojaloop Postman collection
2. Check the result from the Check Transfer status on Payerfsp - ErroInformation step, and verify that it either contains one of the following errors (depending on the timing of when the Postman validation-test queries the PayerFSP for the callback result):
   - EXPIRED_ERROR: { code: '3300', message: 'Generic expired error' } <-- This is the callback sent from the transfer being timed-out as a result of the Prepare-request (https://github.com/mojaloop/central-ledger/blob/master/src/handlers/positions/handler.js#L234).
   - TRANSFER_EXPIRED: { code: '3303', message: 'Transfer expired'} <-- This is the callback sent from the transfer GET-Request (https://github.com/mojaloop/central-ledger/blob/master/src/handlers/transfers/handler.js#L593).

Specifications

• Component (if known): Central-Ledger
• Version: v11.x
• Platform: Dev1, Dev2, Perf3
• Subsystem: n/a
• Type of testing: Manual
• Bug found/raised by: @mdebarros

Notes:

• Severity when opened: Medium
• Priority when opened: Medium

[mdebarros]

PR: mojaloop/central-ledger#795

[mdebarros]

Fix included in v11.3.3 of central-ledger: https://github.com/mojaloop/central-ledger/releases/tag/v11.3.3