-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mojaloop Helm support for Kubernetes networking.k8s.io/v1 (Ingress) Pts 5 #2352
Comments
hey @elnyry-sam-k , @mdebarros @lewisdaly : I assigned this issue to myself because as part of the mini-loop update I want to be able to use k3s and possibly other kubernetes engines and v1.20 is starting to be very problematic indeed and enabling other k8s engines means solving this issue. Now I know it is part of the v14 activities BUT I think I can solve this one programmatically with a "reasonably straight-forward python program to make the mods necessary for the ingress and ingress class (plus the minor changes in the ingress synytax). So I plan to assess this/test this a bit to see just how hard it might be to make 3.x work across releases. I will report back. |
Hey @elnyry-sam-k , @mdebarros I said I was going to open a new issue but then I discovered we already have this open issue so I am updating it to reflect the decision from the DA on separating out the services from the rest of the charts as this is the solution to the this issue. I am now working on this admittedly a couple of weeks behind what I hoped , but it should not take too long for me to get you something to test. |
Separated the |
@mdebarros , @elnyry-sam-k the API changes are done and charts are deploying and tests passing with k8s 1.21. I will check V1.24 shortly but I anticipate issues with the DB due to that percona chart but obviously I can work around that. I have some cosmetic fixes to do in the values files which I would prefer NOT to do by hand. Anyhow nearly there with this issues |
fix(mojaloop/#2352)/14.1.0 - mojaloop/project#2352 - fixes for CGS test-cases to compare current interchangeFeeBalance against previous Balance instead of assuming it will be 0.
…rking v1 (#508) feat(mojaloop/#2352): update and standardise helm charts to use networking v1 - mojaloop/project#2352 # Notes This PR is re-created from #506 which includes some fixes based on tests on k8s v1.24 # Changes: ## Update the Chart.yaml's and standardise all charts to helm v3 (API v2) - move any dependencies in the requirements.yaml to Charts.yaml - update the apiVersion for helm in all the Charts.yaml to 2.0 - add the common dependency to each chart that already has an ingress - remove all requirements.lock - update maintainers in chart.yaml to include tomd@crosslaketech.com - bump chart versions ## Update the ingress and networking API to v1 and standardise where possible - if the chart has an ingress template the chart is not on the exclusion list (see below) => the ingress template is updated to be a clone of the bitnami example (a version of what already exists in the charts repo) - updates the values files for the new ingress settings - ensure the updated values files have the correct hostname for the ingress - checks for paths and extra paths correctly allowed for (i.e. all charts with extraPaths or extraHosts are on e - ensure the updated values files have the correct port number for the ingress - update config/default.json files for values.ingress.api.host or similar to use .Values.ingress.hostname - _helper.tpl's updated to use correct ingress APIs and remove redundant ingress logic and templates ## General Maintenance - Fixed lint issue - Removed forensicloggingsidecar, centralenduserregistry, kube-system from lint scripts since they are no longer supported - Updated Maintainers list for each chart ## Exclusion list of charts - i.e. these charts are not yet standardised to the new ingress modeled on the bitnami example : - Any existing ingress in these charts has been updated "in place" rather than replaced with the newer standardised bitnami modeled chart. - So the ingress.yaml, config/*json, _helper.tpls , values.yaml files etc have been updated to use the latest ingress but they remain non-standard compared to the rest of the code-base. - "finance-portal-settlement-management", - "finance-portal", - ~"thirdparty"~, - ~"thirdparty/chart-tp-api-svc"~, - ~"thirdparty/chart-consent-oracle"~, - ~"thirdparty/chart-auth-svc"~, - ~"mojaloop-simulator"~, - "keycloak", - "monitoring", - "monitoring/promfana", - "monitoring/elk", - "ml-testing-toolkit/chart-keycloak", - "ml-testing-toolkit/chart-backend", - "ml-testing-toolkit/chart-frontend", - "ml-testing-toolkit/chart-connection-manager-backend", - "ml-testing-toolkit/chart-connection-manager-frontend" Co-authored-by: tdaly61 <tdaly61@gmail.com> Co-authored-by: Sam <10507686+elnyry-sam-k@users.noreply.github.com>
PR (mojaloop/helm#508) has been merged, and we now have a development release :D/
Thanks to @tdaly61 for the PR! |
Dev Release TestDev release tests with default config except for the following changes:
Results
|
* feat(mojaloop/#2352): update and standardise helm charts to use networking v1 (#508) feat(mojaloop/#2352): update and standardise helm charts to use networking v1 - mojaloop/project#2352 # Notes This PR is re-created from #506 which includes some fixes based on tests on k8s v1.24 # Changes: ## Update the Chart.yaml's and standardise all charts to helm v3 (API v2) - move any dependencies in the requirements.yaml to Charts.yaml - update the apiVersion for helm in all the Charts.yaml to 2.0 - add the common dependency to each chart that already has an ingress - remove all requirements.lock - update maintainers in chart.yaml to include tomd@crosslaketech.com - bump chart versions ## Update the ingress and networking API to v1 and standardise where possible - if the chart has an ingress template the chart is not on the exclusion list (see below) => the ingress template is updated to be a clone of the bitnami example (a version of what already exists in the charts repo) - updates the values files for the new ingress settings - ensure the updated values files have the correct hostname for the ingress - checks for paths and extra paths correctly allowed for (i.e. all charts with extraPaths or extraHosts are on e - ensure the updated values files have the correct port number for the ingress - update config/default.json files for values.ingress.api.host or similar to use .Values.ingress.hostname - _helper.tpl's updated to use correct ingress APIs and remove redundant ingress logic and templates ## General Maintenance - Fixed lint issue - Removed forensicloggingsidecar, centralenduserregistry, kube-system from lint scripts since they are no longer supported - Updated Maintainers list for each chart ## Exclusion list of charts - i.e. these charts are not yet standardised to the new ingress modeled on the bitnami example : - Any existing ingress in these charts has been updated "in place" rather than replaced with the newer standardised bitnami modeled chart. - So the ingress.yaml, config/*json, _helper.tpls , values.yaml files etc have been updated to use the latest ingress but they remain non-standard compared to the rest of the code-base. - "finance-portal-settlement-management", - "finance-portal", - ~"thirdparty"~, - ~"thirdparty/chart-tp-api-svc"~, - ~"thirdparty/chart-consent-oracle"~, - ~"thirdparty/chart-auth-svc"~, - ~"mojaloop-simulator"~, - "keycloak", - "monitoring", - "monitoring/promfana", - "monitoring/elk", - "ml-testing-toolkit/chart-keycloak", - "ml-testing-toolkit/chart-backend", - "ml-testing-toolkit/chart-frontend", - "ml-testing-toolkit/chart-connection-manager-backend", - "ml-testing-toolkit/chart-connection-manager-frontend" Co-authored-by: tdaly61 <tdaly61@gmail.com> Co-authored-by: Sam <10507686+elnyry-sam-k@users.noreply.github.com> * fix: als-admin api ingress service port (#511) - fixed als-admin api ingress service port from 4002 to 4001 - fixed formatting issues in for protocol_versions configs * fix(mojaloop/2995): update ttk-ui (#512) * chore: bumped up ttk-ui * chore: some change in appversion * fix: als-admin api ingress service port (#513) - fixed als api ingress service port fix from 4002/4001 to 80 - fixed formatting issues in for protocol_versions configs * chore: updated TTK and fixed some values * feat: added example backend chart for mojaloop (#517) feat: added example backend chart for mojaloop (#517) - mojaloop/project#3000 - updated mojaloop/values.yaml to include CONFIG section with YAML Anchor variables to make configurations easier - added example-mojaloop-backend for external backend dependencies to enable deployments on Kubernetes v1.22+ - updated shell helper scripts to include example-mojaloop-backend charts - updates CI config to add helm dependency repos and updated readme Co-authored-by: Miguel de Barros <miguel@debarros.me> * updates to chart appVersion description * fix: changed the default jws file path in sdk helm chart * fix: sdk helm values Co-authored-by: Miguel de Barros <miguel@debarros.me> Co-authored-by: tdaly61 <tdaly61@gmail.com> Co-authored-by: Sam <10507686+elnyry-sam-k@users.noreply.github.com>
Goal:
As a
Mojaloop DeployerI want to
update API versions in Helm chartsso that
I can deploy a Mojaloop Release to Kubernetes v1.22 onwardsAcceptance Criteria:
networking.k8s.io/v1beta1
tonetworking.k8s.io/v1
, ref: https://kubernetes.io/docs/reference/using-api/deprecation-guide/#ingress-v122Complexity: Medium
Uncertainty: Medium
Tasks:
Done
Pull Requests:
Follow-up:
Dependencies:
Accountability:
The text was updated successfully, but these errors were encountered: