Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align liquidity calculations for both the Settlement and Transfer Processes #2927

Open
11 tasks
mdebarros opened this issue Sep 9, 2022 · 0 comments
Open
11 tasks
Labels
core-dev-squad oss-core This is an issue - story or epic related to a feature on a Mojaloop core service or related to it story to-be-refined This story is ready to be groomed

Comments

@mdebarros
Copy link
Member

mdebarros commented Sep 9, 2022

Goal:

As a Mojaloop

I want to make the liquidity calculations & check-comparisons between the position account and the settled funds account as modified by the NDC, instead of between the position account and the NDC as part of the Settlement Process

so that liquidity calculations & checks are aligned for both the Settlement and Transfer Processes

This is a follow-up story to the following:

Acceptance Criteria:

  • Verify liquidity check comparison between the position account and the settled funds account as modified by the NDC, instead of between the position account and the NDC as part of the Settlement Process
  • Utilise ML-Number library to handle all mathematical operations within the Settlement Gross Handler
    • model.transferSettlement.facade.updateTransferSettlement function

Complexity: High

Uncertainty: Medium


Tasks:

  • TBD [ @? ]

Done

  • Acceptance Criteria pass
  • Designs are up-to date
  • Unit Tests pass
  • Integration Tests pass
  • Code Style & Coverage meets standards
  • Changes made to config (default.json) are broadcast to team and follow-up tasks added to update helm charts and other deployment config.
  • TBD

Pull Requests:

  • TBD

Follow-up:

  • N/A

Dependencies:

  • N/A

Accountability:

  • Owner: TBC
  • QA/Review: TBC
@mdebarros mdebarros added story to-be-refined This story is ready to be groomed oss-core This is an issue - story or epic related to a feature on a Mojaloop core service or related to it core-dev-squad labels Sep 9, 2022
@mdebarros mdebarros changed the title Align liquidity check comparison for both the Settlement and Transfer Processes Align liquidity calculations for both the Settlement and Transfer Processes Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-dev-squad oss-core This is an issue - story or epic related to a feature on a Mojaloop core service or related to it story to-be-refined This story is ready to be groomed
Projects
None yet
Development

No branches or pull requests

1 participant