Simplify liquidity cover check and fix issue with validation #2880

elnyry-sam-k · 2022-08-17T16:30:09Z

Goal:

As a Hub Operator

I would like to add an additional check on top of the Net-debit-cap check to validate liquidity cover (settlementPosition balance)

so that defaulting DFSP risk can be reduced

Notes:
This is not the initial implementation of the issue. This enhances existing implementation by simplifying it and fixing related issues. Follow-up to implementation after DA issue: mojaloop/design-authority-project#90. Review the DA issue for further information (approved by DA).

Acceptance Criteria:

Verify that transactions larger than the difference between the settlement account balance and the position account balance are prevented even when the NDC check allows the transaction.((position + transaction amount < settlement account balance) AND (position + transaction amount < NDC - )) → Transfer Allowed to Continue
Verify that the correct distinct error Code is returned for both failure scenarios
- 4001: Insufficient Liquidity - Check against the settlement account balance
- 4200: Payer limit error - Check against NDC
Verify that the transactions larger than the difference between the NDC and the position account balances are prevented.transaction amount > NDC - position → Insufficient liquidity
Verify that the existing GP TTK tests are adjusted to reflect the new liquidity checks (and any funds-in requests needed)
~~Utilise ML-Number library to handle all mathematical operations within the Settlement Gross Handler~~ <-- Align liquidity calculations for both the Settlement and Transfer Processes #2927 has been created to address this issue.
- ~~model.transferSettlement.facade.updateTransferSettlement function~~

Complexity: Medium

Uncertainty: Low

Tasks:

Simplify liquidity check by eliminating separate checks that were based on settlement models - "immediate" or "deferred"
Fix issue to use correct settlementaccountbalance for the additional check (recently added check on top of the usual NDC check)
Add TTK requests to add funds-in for setup
Add TTK tests for regression testing
Create snapshot-releases to run TTK GP test-suite against
TTK GP tests pass
Mojaloop dev release
Patch v14 release

Done

Acceptance Criteria pass
Designs are up-to date
Unit Tests pass
Integration Tests pass
Code Style & Coverage meets standards
Changes made to config (default.json) are broadcast to team and follow-up tasks added to update helm charts and other deployment config.
TBD

Pull Requests:

TBD

Follow-up:

Failures in daily cron job running GP tests #2734

Dependencies:

N/A

Accountability:

Owner: TBC
QA/Review: TBC

The text was updated successfully, but these errors were encountered:

…th validation feat(mojaloop/#2880): simplify liquidity cover check and fix issue with validation - mojaloop/project#2880 - fixed logger module names for deferred and gross handlers - updated modle.transferSettlement.facade.updateTransferSettlement to correctly capture participantPositionChange entries - added some comments to help clarify whats going on in the modle.transferSettlement.facade.updateTransferSettlement

…th validation feat(mojaloop/#2880): simplify liquidity cover check and fix issue with validation - mojaloop/project#2880 - Simplified and consolidated Liquidity check for both Immediate and Deferred with the Position Handler - Cleaned up some code and utilised local variables for consistency

mdebarros · 2022-08-18T18:22:33Z

PR for consideration:

feat(mojaloop/#2880): simplify liquidity cover check and fix issue with validation central-ledger#917 <-- for v15.1.2 release
feat(mojaloop/#2880): simplify liquidity cover check and fix issue with validation (for master) central-ledger#918 <-- for master branch
feat(mojaloop/#2880): simplify liquidity cover check and fix issue with validation central-settlement#384
feat(mojaloop/#2880): simplify liquidity cover check and fix issue with validation testing-toolkit-test-cases#84 <-- supporting change to GP Test-cases for v14.0.0 release
feat(mojaloop/#2880): simplify liquidity cover check and fix issue with validation (master) testing-toolkit-test-cases#85 <-- same but for master branch

mdebarros · 2022-08-18T18:24:20Z

Useful queries

SELECT * from central_ledger.participantPositionChange WHERE participantPositionId IN ('64', '36') AND createdDate > '2022-08-18 17:58:00' order by createdDate desc;

SELECT * from central_ledger.participantPositionChange WHERE  createdDate > '2022-08-18 17:58:00' order by createdDate desc;

For transferParticipantId Insert

select TP.transferParticipantId, TP.transferId, TP.participantCurrencyId, TP.transferParticipantRoleTypeId, TP.ledgerEntryTypeId, TP.amount * -1 from transferParticipant as TP
inner join participantCurrency as PC on TP.participantCurrencyId = PC.participantCurrencyId
inner join settlementModel as M on PC.ledgerAccountTypeId = M.ledgerAccountTypeId 
inner join settlementGranularity as G on M.settlementGranularityId = G.settlementGranularityId 
where (TP.transferId = 'f9e605e8-5e53-4b99-995e-166ab38a1853' and (G.name = 'GROSS'))
union 
	select TP.transferParticipantId, TP.transferId, PC1.participantCurrencyId, TP.transferParticipantRoleTypeId, TP.ledgerEntryTypeId, TP.amount * +1 from transferParticipant as TP 
    inner join participantCurrency as PC on TP.participantCurrencyId = PC.participantCurrencyId 
    inner join settlementModel as M on PC.ledgerAccountTypeId = M.ledgerAccountTypeId 
    inner join settlementGranularity as G on M.settlementGranularityId = G.settlementGranularityId 
    inner join participantCurrency as PC1 on PC1.currencyId = PC.currencyId and PC1.participantId = PC.participantId and PC1.ledgerAccountTypeId = M.settlementAccountTypeId 
    where (TP.transferId = 'f9e605e8-5e53-4b99-995e-166ab38a1853' and (G.name = 'GROSS'));

For participantPositionChange Insert

select TP.transferParticipantId, TP.transferId, TP.participantCurrencyId, TP.transferParticipantRoleTypeId, TP.ledgerEntryTypeId, TP.amount * +1 from transferParticipant as TP
inner join participantCurrency as PC on TP.participantCurrencyId = PC.participantCurrencyId
inner join settlementModel as M on PC.ledgerAccountTypeId = M.ledgerAccountTypeId 
inner join settlementGranularity as G on M.settlementGranularityId = G.settlementGranularityId 
where (TP.transferId = 'f9e605e8-5e53-4b99-995e-166ab38a1853' and (G.name = 'GROSS'))
union 
	select TP.transferParticipantId, TP.transferId, PC1.participantCurrencyId, TP.transferParticipantRoleTypeId, TP.ledgerEntryTypeId, TP.amount * -1 from transferParticipant as TP 
    inner join participantCurrency as PC on TP.participantCurrencyId = PC.participantCurrencyId 
    inner join settlementModel as M on PC.ledgerAccountTypeId = M.ledgerAccountTypeId 
    inner join settlementGranularity as G on M.settlementGranularityId = G.settlementGranularityId 
    inner join participantCurrency as PC1 on PC1.currencyId = PC.currencyId and PC1.participantId = PC.participantId and PC1.ledgerAccountTypeId = M.settlementAccountTypeId 
    where (TP.transferId = 'f9e605e8-5e53-4b99-995e-166ab38a1853' and (G.name = 'GROSS'));

…th validation feat(mojaloop/#2880): simplify liquidity cover check and fix issue with validation - mojaloop/project#2880 - fixes to collections/hub/golden_path/feature_tests/block_transfers - aligned liquidity and position calculations with central-ledger logic - cleaned up unecessary requests (i.e. why have two requests to fetch settlement and position accounts when it can be done in one?)

mdebarros · 2022-08-26T16:58:38Z

Follow-up stories:

Story to review the need for reservedValue in the Admin API spec for GET /participants/{name}/accounts (and other operations)
Enhance existing GP Test-case to include Balance Checks (I.e. Position, Reserved-Position, Settlement, Interchange) if/where required

TODO:

Create snapshot-releases to run TTK GP test-suite against
Action any TODO's on each PR

feat(mojaloop/#2880): simplify liquidity cover check and fix issue with validation - mojaloop/project#2880 - upgraded central-ledger from v15.1.2 to v15.1.2.1-snapshot.1

feat(mojaloop/#2880): simplify liquidity cover check and fix issue with validation - mojaloop/project#2880 - upgraded central-settlements from v14.0.0 to v14.0.0.1-snapshot.1

…th validation (#84) feat(mojaloop/#2880): simplify liquidity cover check and fix issue with validation - mojaloop/project#2880 - fixes to collections/hub/golden_path/feature_tests/block_transfers - aligned liquidity and position calculations with central-ledger logic - cleaned up unnecessary requests (i.e. why have two requests to fetch settlement and position accounts when it can be done in one?) - re-factored `[new sims] transfers, positions CGS Window1 tests (OTC-649, OTC-645)` @ collections/hub/golden_path/settlement_cgs/newsetcgs - standardised naming convention - re-aligned position, settlement and interchange checks with central-ledger logic, and expanded on checks dynamically based on the transfer amounts (`Tx1`, `Tx2`, `Tx3`, `Tx4`, `Tx5`, `Tx6`) instead of using "hard-coded" values - consolidated separate `GET /account` test-case for settlement, and positions into a single test-case (i.e. only need one call to admin API to retrieve balances and do validation checks) - added new OPTIONAL env vars for: 1. `SETTLEMENT_CGS_TX_AMOUNT_1` (defaults: 15), `SETTLEMENT_CGS_TX_AMOUNT_2` (defaults: 87.88), `SETTLEMENT_CGS_TX_AMOUNT_3` (defaults: 158.36), `SETTLEMENT_CGS_TX_AMOUNT_4` (defaults: 211.11), `SETTLEMENT_CGS_TX_AMOUNT_5` (defaults: 14.05), `SETTLEMENT_CGS_TX_AMOUNT_6` (defaults: 150) representing the transfer amounts for each Transaction. These correlate to `Tx1`...`Tx6` 2. `SETTLEMENT_RULE_INTERCHANGE_FEE` (defaults: 0.006) which is the Interchange Fee % used to calculate the aggregate Fee fix(mojaloop/#2734): failures in daily cron job running GP tests - mojaloop/project#2734 - added re-try logic to create interchange-fee settlements as part of CGS test-suite - bumped up RETRY_MAX_ATTEMPTS (10 to 20) & RETRY_MAX_WAIT_IN_MS (200 to 250) values to improve stability

…th validation (#384) feat(mojaloop/#2880): simplify liquidity cover check and fix issue with validation - mojaloop/project#2880 - fixed logger module names for deferred and gross handlers - updated `model.transferSettlement.facade.updateTransferSettlement` to correctly capture participantPositionChange entries - added some comments to help clarify whats going on in the modle.transferSettlement.facade.updateTransferSettlement chore: maintenance - updated dependencies - standardised package.json order - removed deprecated faucet and replace with tap-spec, and updated associated npm test scripts - replaced npm-audit-resolve with audit-ci - audit fixes

…th validation (#917) feat(mojaloop/#2880): simplify liquidity cover check and fix issue with validation - mojaloop/project#2880 - Simplified and consolidated Liquidity check for both Immediate and Deferred with the Position Handler - Cleaned up some code and utilised local variables for consistency - added todo for the reservedValue being returned when retrieving account information via the Admin API which does not conform to the API Spec. If there is any reservedValue, the position returned by the Admin API should calculated the "effectivePosition" as the actual position instead of returning the reservedValue. chore: maintenance - updated dependencies & fixed audit issues - replaced audit-resolve with audit-ci

…th validation (for master) (#918) feat(mojaloop/#2880): simplify liquidity cover check and fix issue with validation - mojaloop/project#2880 - Simplified and consolidated Liquidity check for both Immediate and Deferred with the Position Handler - Cleaned up some code and utilised local variables for consistency - added todo for the reservedValue being returned when retrieving account information via the Admin API which does not conform to the API Spec. If there is any reservedValue, the position returned by the Admin API should calculated the "effectivePosition" as the actual position instead of returning the reservedValue. chore: maintenance - updated dependencies & fixed audit issues - replaced audit-resolve with audit-ci

…th validation (master) (#86) feat(mojaloop/#2880): simplify liquidity cover check and fix issue with validation - mojaloop/project#2880 - fixes to collections/hub/golden_path/feature_tests/block_transfers - aligned liquidity and position calculations with central-ledger logic - cleaned up unnecessary requests (i.e. why have two requests to fetch settlement and position accounts when it can be done in one?) - re-factored `[new sims] transfers, positions CGS Window1 tests (OTC-649, OTC-645)` @ collections/hub/golden_path/settlement_cgs/newsetcgs - standardised naming convention - re-aligned position, settlement and interchange checks with central-ledger logic, and expanded on checks dynamically based on the transfer amounts (`Tx1`, `Tx2`, `Tx3`, `Tx4`, `Tx5`, `Tx6`) instead of using "hard-coded" values - consolidated separate `GET /account` test-case for settlement, and positions into a single test-case (i.e. only need one call to admin API to retrieve balances and do validation checks) - added new OPTIONAL env vars for: 1. `SETTLEMENT_CGS_TX_AMOUNT_1` (defaults: 15), `SETTLEMENT_CGS_TX_AMOUNT_2` (defaults: 87.88), `SETTLEMENT_CGS_TX_AMOUNT_3` (defaults: 158.36), `SETTLEMENT_CGS_TX_AMOUNT_4` (defaults: 211.11), `SETTLEMENT_CGS_TX_AMOUNT_5` (defaults: 14.05), `SETTLEMENT_CGS_TX_AMOUNT_6` (defaults: 150) representing the transfer amounts for each Transaction. These correlate to `Tx1`...`Tx6` 2. `SETTLEMENT_RULE_INTERCHANGE_FEE` (defaults: 0.006) which is the Interchange Fee % used to calculate the aggregate Fee fix(mojaloop/#2734): failures in daily cron job running GP tests - mojaloop/project#2734 - added re-try logic to create interchange-fee settlements as part of CGS test-suite - bumped up RETRY_MAX_ATTEMPTS (10 to 20) & RETRY_MAX_WAIT_IN_MS (200 to 250) values to improve stability

mdebarros · 2022-09-08T09:06:01Z

Executed multiple tests based TTK Test-Case release v14.0.0.1.

This includes the following snapshots:

central-ledger: v15.1.2.1-snapshot.3
central-settlement: v14.0.0.1-snapshot.1
mojaloop-simulator: v13.0.1-snapshot.1

Starting at approximately 6:20pm UTC (2022/09/08), ran multiple consecutive tests without failure, and an additional test the following morning @ 9:00am UTC. All test passed successfully without failures.

Reports for 2022-09-07

Reports for 2022-09-08

View Report @ 8:23am UTC
View Report @ 9:02am UTC (re-deployment)

…th validation (#496) feat(mojaloop/[#2880](https://github.com/mdebarros/helm/issues/2880)): simplify liquidity cover check and fix issue with validation - mojaloop/project#2880 - upgraded mojaloop-simulator to v13.0.1 - upgraded central-settlement to v15.0.0 - upgraded central-ledger to v15.1.2.1 - updated TTK Test-Collection to v14.0.0.1 fix(mojaloop/#2734): Failures in daily cron job running GP tests - mojaloop/project#2734 - Included stability fixes in TTK Test-Collection to v14.0.0.1 release

mdebarros · 2022-09-09T14:33:22Z

Moja1

Deployment

❯ helm -n moja1 list
NAME    NAMESPACE       REVISION        UPDATED                                 STATUS          CHART                           APP VERSION                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                  
moja1   moja1           1               2022-09-09 16:07:32.685854 +0200 SAST   deployed        mojaloop-14.0.0-13942.8ece499   ml-api-adapter: v14.0.0; central-ledger: v15.1.2.1; account-lookup-service: v13.0.0; quoting-service: v15.0.2; central-settlement: v15.0.0; central-event-processor: v12.0.0; bulk-api-adapter: v13.0.1; email-notifier: v12.0.0; als-oracle-pathfinder: v12.0.0; transaction-requests-service: v14.0.1; simulator: v12.0.0; mojaloop-simulator: v13.0.1; sdk-scheme-adapter: v18.0.2; thirdparty-sdk: v15.1.0; ml-testing-toolkit: v15.0.0; ml-testing-toolkit-ui: v15.0.0;

Test Results

Testing Toolkit Report
Test Result: PASSED
Test Suite: GP Tests
Environment: moja1.test.mojaloop.live@v14.0.0
Total assertions: 2634
Passed assertions: 2634
Failed assertions: 0
Total requests: 598
Total test cases: 130
Passed percentage: 100.00%
Started time: Fri, 09 Sep 2022 14:20:47 GMT
Completed time: Fri, 09 Sep 2022 14:24:06 GMT
Runtime duration: 198710 ms

View Report

Testing Toolkit Report
Test Result: PASSED
Test Suite: Bulk Tests
Environment: moja1.test.mojaloop.live@v14.0.0
Total assertions: 183
Passed assertions: 183
Failed assertions: 0
Total requests: 17
Total test cases: 4
Passed percentage: 100.00%
Started time: Fri, 09 Sep 2022 14:25:09 GMT
Completed time: Fri, 09 Sep 2022 14:25:33 GMT
Runtime duration: 24898 ms

View Report

Testing Toolkit Report
Test Result: PASSED
Test Suite: Thirdparty Tests
Environment: moja1.test.mojaloop.live@v14.0.0
Total assertions: 21
Passed assertions: 21
Failed assertions: 0
Total requests: 20
Total test cases: 8
Passed percentage: 100.00%
Started time: Fri, 09 Sep 2022 14:28:23 GMT
Completed time: Fri, 09 Sep 2022 14:28:30 GMT
Runtime duration: 7504 ms

View Report

mdebarros · 2022-09-09T14:43:14Z

Default

Deployment

❯ helm -n moja3 list
NAME    NAMESPACE       REVISION        UPDATED                                 STATUS          CHART                           APP VERSION                                                                                                                                                                                                                                                                                                                                                                                                                                                                 
moja3   moja3           1               2022-09-09 16:29:23.902667 +0200 SAST   deployed        mojaloop-14.0.0-13942.8ece499   ml-api-adapter: v14.0.0; central-ledger: v15.1.2.1; account-lookup-service: v13.0.0; quoting-service: v15.0.2; central-settlement: v15.0.0; central-event-processor: v12.0.0; bulk-api-adapter: v13.0.1; email-notifier: v12.0.0; als-oracle-pathfinder: v12.0.0; transaction-requests-service: v14.0.1; simulator: v12.0.0; mojaloop-simulator: v13.0.1; sdk-scheme-adapter: v18.0.2; thirdparty-sdk: v15.1.0; ml-testing-toolkit: v15.0.0; ml-testing-toolkit-ui: v15.0.0;

Test Results

--------------------FINAL REPORT--------------------
Test Suite:GP Tests
Environment:Development
┌───────────────────────────────────────────────────┐
│                      SUMMARY                      │
├───────────────────┬───────────────────────────────┤
│ Total assertions  │ 2634                          │
├───────────────────┼───────────────────────────────┤
│ Passed assertions │ 2634                          │
├───────────────────┼───────────────────────────────┤
│ Failed assertions │ 0                             │
├───────────────────┼───────────────────────────────┤
│ Total requests    │ 598                           │
├───────────────────┼───────────────────────────────┤
│ Total test cases  │ 130                           │
├───────────────────┼───────────────────────────────┤
│ Passed percentage │ 100.00%                       │
├───────────────────┼───────────────────────────────┤
│ Started time      │ Fri, 09 Sep 2022 14:37:48 GMT │
├───────────────────┼───────────────────────────────┤
│ Completed time    │ Fri, 09 Sep 2022 14:41:06 GMT │
├───────────────────┼───────────────────────────────┤
│ Runtime duration  │ 198659 ms                     │
└───────────────────┴───────────────────────────────┘
TTK-Assertion-Report-multi-2022-09-09T14:41:06.667Z.html was generated

mdebarros · 2022-09-12T09:58:52Z

Helm v14.0.0 Rev-2 release:

❯ helm search repo mojaloop/mojaloop --max-col-width 900
NAME                       	CHART VERSION	APP VERSION                                                                                                                                                                                                                                                                                                                                                                                                                                                               	DESCRIPTION
mojaloop/mojaloop          	14.0.0       	ml-api-adapter: v14.0.0; central-ledger: v15.1.0; account-lookup-service: v13.0.0; quoting-service: v15.0.2; central-settlement: v14.0.0; central-event-processor: v12.0.0; bulk-api-adapter: v13.0.1; email-notifier: v12.0.0; als-oracle-pathfinder: v12.0.0; transaction-requests-service: v14.0.1; simulator: v12.0.0; mojaloop-simulator: v13.0.0; sdk-scheme-adapter: v18.0.2; thirdparty-sdk: v15.1.0; ml-testing-toolkit: v15.0.0; ml-testing-toolkit-ui: v15.0.0;	Mojaloop Helm chart for Kubernetes
mojaloop/mojaloop-bulk     	14.0.0       	bulk-api-adapter: v14.0.0; central-ledger: v15.1.0                                                                                                                                                                                                                                                                                                                                                                                                                        	Mojaloop Bulk Helm chart for Kubernetes
mojaloop/mojaloop-simulator	14.0.0       	sdk-scheme-adapter: v18.0.2; mojaloop-simulator: v13.0.0; thirdparty-sdk: v15.1.0                                                                                                                                                                                                                                                                                                                                                                                         	Helm Chart for the Mojaloop (SDK-based) Simulator
❯ helm repo update
Hang tight while we grab the latest from your chart repositories...
...Successfully got an update from the "reporting-k8s-templates" chart repository
...Successfully got an update from the "bitnami" chart repository
...Successfully got an update from the "mojaloop-charts" chart repository
...Successfully got an update from the "mojaloop" chart repository
Update Complete. ⎈Happy Helming!⎈
❯ helm search repo mojaloop/mojaloop --max-col-width 900
NAME                       	CHART VERSION	APP VERSION                                                                                                                                                                                                                                                                                                                                                                                                                                                                 	DESCRIPTION
mojaloop/mojaloop          	14.0.0       	ml-api-adapter: v14.0.0; central-ledger: v15.1.2.1; account-lookup-service: v13.0.0; quoting-service: v15.0.2; central-settlement: v15.0.0; central-event-processor: v12.0.0; bulk-api-adapter: v13.0.1; email-notifier: v12.0.0; als-oracle-pathfinder: v12.0.0; transaction-requests-service: v14.0.1; simulator: v12.0.0; mojaloop-simulator: v13.0.1; sdk-scheme-adapter: v18.0.2; thirdparty-sdk: v15.1.0; ml-testing-toolkit: v15.0.0; ml-testing-toolkit-ui: v15.0.0;	Mojaloop Helm chart for Kubernetes
mojaloop/mojaloop-bulk     	14.0.0       	bulk-api-adapter: v14.0.0; central-ledger: v15.1.2.1                                                                                                                                                                                                                                                                                                                                                                                                                        	Mojaloop Bulk Helm chart for Kubernetes
mojaloop/mojaloop-simulator	14.0.0       	sdk-scheme-adapter: v18.0.2; mojaloop-simulator: v13.0.1; thirdparty-sdk: v15.1.0                                                                                                                                                                                                                                                                                                                                                                                           	Helm Chart for the Mojaloop (SDK-based) Simulator

mdebarros · 2022-09-12T14:03:32Z

Moja1

Deployment

❯ helm -n moja1 list
NAME 	NAMESPACE	REVISION	UPDATED                              	STATUS  	CHART                      	APP VERSION
moja1	moja1    	1       	2022-09-12 13:37:36.870681 +0200 SAST	deployed	mojaloop-14.0.0            	ml-api-adapter: v14.0.0; central-ledger: v15.1.2.1; account-lookup-service: v13.0.0; quoting-service: v15.0.2; central-settlement: v15.0.0; central-event-processor: v12.0.0; bulk-api-adapter: v13.0.1; email-notifier: v12.0.0; als-oracle-pathfinder: v12.0.0; transaction-requests-service: v14.0.1; simulator: v12.0.0; mojaloop-simulator: v13.0.1; sdk-scheme-adapter: v18.0.2; thirdparty-sdk: v15.1.0; ml-testing-toolkit: v15.0.0; ml-testing-toolkit-ui: v15.0.0;

Test Results

Testing Toolkit Report
Test Result: PASSED
Test Suite: GP Tests
Environment: moja1.test.mojaloop.live@v14.0.0
Total assertions: 2634
Passed assertions: 2634
Failed assertions: 0
Total requests: 598
Total test cases: 130
Passed percentage: 100.00%
Started time: Mon, 12 Sep 2022 13:52:40 GMT
Completed time: Mon, 12 Sep 2022 13:55:47 GMT
Runtime duration: 187152 ms

View Report

Testing Toolkit Report
Test Result: PASSED
Test Suite: Bulk Tests
Environment: moja1.test.mojaloop.live@v14.0.0
Total assertions: 183
Passed assertions: 183
Failed assertions: 0
Total requests: 17
Total test cases: 4
Passed percentage: 100.00%
Started time: Mon, 12 Sep 2022 13:56:30 GMT
Completed time: Mon, 12 Sep 2022 13:56:55 GMT
Runtime duration: 24807 ms

View Report

Testing Toolkit Report
Test Result: PASSED
Test Suite: Thirdparty Tests
Environment: moja1.test.mojaloop.live@v14.0.0
Total assertions: 21
Passed assertions: 21
Failed assertions: 0
Total requests: 20
Total test cases: 8
Passed percentage: 100.00%
Started time: Mon, 12 Sep 2022 13:58:02 GMT
Completed time: Mon, 12 Sep 2022 13:58:09 GMT
Runtime duration: 7186 ms

View Report

mdebarros · 2022-09-12T14:23:05Z

Moja3 (Default)

Deployment

❯ helm -n moja3 list
NAME 	NAMESPACE	REVISION	UPDATED                              	STATUS  	CHART          	APP VERSION
moja3	moja3    	1       	2022-09-12 16:01:21.614392 +0200 SAST	deployed	mojaloop-14.0.0	ml-api-adapter: v14.0.0; central-ledger: v15.1.2.1; account-lookup-service: v13.0.0; quoting-service: v15.0.2; central-settlement: v15.0.0; central-event-processor: v12.0.0; bulk-api-adapter: v13.0.1; email-notifier: v12.0.0; als-oracle-pathfinder: v12.0.0; transaction-requests-service: v14.0.1; simulator: v12.0.0; mojaloop-simulator: v13.0.1; sdk-scheme-adapter: v18.0.2; thirdparty-sdk: v15.1.0; ml-testing-toolkit: v15.0.0; ml-testing-toolkit-ui: v15.0.0;

Tests

--------------------FINAL REPORT--------------------

Test Suite:GP Tests
Environment:Development
┌───────────────────────────────────────────────────┐
│                      SUMMARY                      │
├───────────────────┬───────────────────────────────┤
│ Total assertions  │ 2634                          │
├───────────────────┼───────────────────────────────┤
│ Passed assertions │ 2634                          │
├───────────────────┼───────────────────────────────┤
│ Failed assertions │ 0                             │
├───────────────────┼───────────────────────────────┤
│ Total requests    │ 598                           │
├───────────────────┼───────────────────────────────┤
│ Total test cases  │ 130                           │
├───────────────────┼───────────────────────────────┤
│ Passed percentage │ 100.00%                       │
├───────────────────┼───────────────────────────────┤

elnyry-sam-k added story oss-core This is an issue - story or epic related to a feature on a Mojaloop core service or related to it core-dev-squad labels Aug 17, 2022

elnyry-sam-k added this to the Sprint 19.2 milestone Aug 17, 2022

chris-me-law assigned mdebarros Aug 18, 2022

This was referenced Aug 18, 2022

feat(mojaloop/#2880): simplify liquidity cover check and fix issue with validation mojaloop/central-ledger#917

Merged

feat(mojaloop/#2880): simplify liquidity cover check and fix issue with validation mojaloop/central-settlement#384

Merged

mdebarros mentioned this issue Aug 18, 2022

feat(mojaloop/#2880): simplify liquidity cover check and fix issue with validation (for master) mojaloop/central-ledger#918

Merged

mdebarros added a commit to mojaloop/helm that referenced this issue Sep 1, 2022

chore: upgrades for central-ledger

d2a22c9

feat(mojaloop/#2880): simplify liquidity cover check and fix issue with validation - mojaloop/project#2880 - upgraded central-ledger from v15.1.2 to v15.1.2.1-snapshot.1

This was referenced Sep 1, 2022

feat(mojaloop/#2880): simplify liquidity cover check and fix issue with validation mojaloop/helm#496

Merged

feat(mojaloop/#2880): simplify liquidity cover check and fix issue with validation (master) mojaloop/testing-toolkit-test-cases#86

Merged

chris-me-law closed this as completed Sep 12, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Simplify liquidity cover check and fix issue with validation #2880

Simplify liquidity cover check and fix issue with validation #2880

elnyry-sam-k commented Aug 17, 2022 •

edited by mdebarros

Loading

mdebarros commented Aug 18, 2022 •

edited

Loading

mdebarros commented Aug 18, 2022 •

edited

Loading

mdebarros commented Aug 26, 2022 •

edited

Loading

mdebarros commented Sep 8, 2022 •

edited

Loading

mdebarros commented Sep 9, 2022 •

edited

Loading

mdebarros commented Sep 9, 2022 •

edited

Loading

mdebarros commented Sep 12, 2022 •

edited

Loading

mdebarros commented Sep 12, 2022 •

edited

Loading

mdebarros commented Sep 12, 2022 •

edited

Loading

Simplify liquidity cover check and fix issue with validation #2880

Simplify liquidity cover check and fix issue with validation #2880

Comments

elnyry-sam-k commented Aug 17, 2022 • edited by mdebarros Loading

Goal:

Pull Requests:

Follow-up:

Accountability:

mdebarros commented Aug 18, 2022 • edited Loading

mdebarros commented Aug 18, 2022 • edited Loading

Useful queries

For transferParticipantId Insert

For participantPositionChange Insert

mdebarros commented Aug 26, 2022 • edited Loading

mdebarros commented Sep 8, 2022 • edited Loading

Reports for 2022-09-07

Reports for 2022-09-08

mdebarros commented Sep 9, 2022 • edited Loading

Moja1

Deployment

Test Results

mdebarros commented Sep 9, 2022 • edited Loading

Default

Deployment

Test Results

mdebarros commented Sep 12, 2022 • edited Loading

mdebarros commented Sep 12, 2022 • edited Loading

Moja1

Deployment

Test Results

mdebarros commented Sep 12, 2022 • edited Loading

Moja3 (Default)

Deployment

Tests

elnyry-sam-k commented Aug 17, 2022 •

edited by mdebarros

Loading

mdebarros commented Aug 18, 2022 •

edited

Loading

mdebarros commented Aug 18, 2022 •

edited

Loading

mdebarros commented Aug 26, 2022 •

edited

Loading

mdebarros commented Sep 8, 2022 •

edited

Loading

mdebarros commented Sep 9, 2022 •

edited

Loading

mdebarros commented Sep 9, 2022 •

edited

Loading

mdebarros commented Sep 12, 2022 •

edited

Loading

mdebarros commented Sep 12, 2022 •

edited

Loading

mdebarros commented Sep 12, 2022 •

edited

Loading