Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Central-Ledger] Investigate why running the Event Handlers inline during Int Tests causes instabilities #3112

Open
mdebarros opened this issue Feb 3, 2023 · 0 comments
Open

[Central-Ledger] Investigate why running the Event Handlers inline during Int Tests causes instabilities #3112

mdebarros opened this issue Feb 3, 2023 · 0 comments
Labels
bug Something isn't working or it has wrong behavior on a Mojaloop Core service core-dev-squad oss-core This is an issue - story or epic related to a feature on a Mojaloop core service or related to it to-be-refined This story is ready to be groomed

Comments

@mdebarros
Copy link
Member

Summary:

Investigate why running the Event Handlers inline during Int Tests causes instabilities.

The Integration Tests have been re-worked to require the Central-Ledger service to be started as a seperate process. This removes the instabilities for the time being, and perhaps is the way we want to execute our Integration Tests going forward (if so, than this bug-report can be closed).

Severity:
Low

Priority:
Low

Expected Behavior

Integration Tests with inline Event Handlers should be stable.

Steps to Reproduce

  1. Enable inline Event Handlers
  2. Start backends with Docker-compose
  3. Run Integration Tests several times

Specifications

  • Component (if known): Central-Ledger
  • Version: 16.4.0
  • Platform: Local and CI
  • Subsystem: Integration Tests
  • Type of testing: N/A
  • Bug found/raised by: @mdebarros

Notes:

  • Severity when opened: Low
  • Priority when opened: Low
@mdebarros mdebarros added bug Something isn't working or it has wrong behavior on a Mojaloop Core service oss-core This is an issue - story or epic related to a feature on a Mojaloop core service or related to it to-be-refined This story is ready to be groomed core-dev-squad labels Feb 3, 2023
This was referenced Feb 3, 2023
Closed
Merged
mdebarros added a commit to mojaloop/central-ledger that referenced this issue Feb 3, 2023
@mdebarros
fix(mojaloop/#3096): unable to upgrade knex dependency on centralLedg…
c376af8 
…er (#939)

fix(mojaloop/#3096): unable to upgrade knex dependency on centralLedger - mojaloop/project#3096
- added UV_THREADPOOL_SIZE config to CI command for running integration tests
- upgraded knex to latest version

The following issue mojaloop/project#3112 was created to investigate as to why the Integration Tests are so unstable when then Event Handlers are executing in-line. For the time being the above PR clearly separates the process which resolves the stability issue for the time being.

The following changes were made as a work-around:
- Integration Tests will no longer start the Event Handlers in-line. You will need to start the Central-Ledger Service as a seperate process (see updated documentation for more information)
- Documentation for Integration Tests updated to reflect the above requirement
- CI Job updated to start the Central-Ledger Service as a seperate Process prior to running Integration Tests
- Added comments to where the commented out code for the initialization of the in-line Event Handlers referencing the above story.
- Also made some changes to the Handler tests to handle failures instead of stalling the Integration Tests

chore: maintenance updates
- fixed audit issues
- added missing kafka topics from docker-compose init kafka container to ensure the CL Service startup is clean
@kalinkrustev kalinkrustev mentioned this issue Mar 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working or it has wrong behavior on a Mojaloop Core service core-dev-squad oss-core This is an issue - story or epic related to a feature on a Mojaloop core service or related to it to-be-refined This story is ready to be groomed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mdebarros