Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK Scheme Adaptor] Extend Payee requestToPay API process to support the validation of the payer details (3pts) #3345

Closed
44 of 45 tasks
PaulGregoryBaker opened this issue May 16, 2023 · 1 comment

Comments

@PaulGregoryBaker
Copy link

PaulGregoryBaker commented May 16, 2023

Goal:

As a DFSP Using SDK and RTP use case
I want to SDK to support RTP
so that continue to use the SDK to connect to Mojaloop for this use case.

Acceptance Criteria:
Payee Outbound modifcations

  • Verify that a separate AUTO_ACCEPT_R2P_PARTY configuration is used for request to pay
  • Verify that a PUT \RequestToPay API end point is available to proceed after that Party information is returned when the AUTO_ACCEPT_R2P_PARTY option is false.
  • Verify that the Authentication type is supplied in the POST \requestToPay
  • Verify that the homeTransactionId is renamed to homeRTPtransactionId

Payer Inbound modification

  • Verify that the POST \transactionRequest is update to
    • include that authentication type
    • Add the homeTransferRequestId to the sync response
    • Rename the TransferAmount to TransactionRequestState
  • Verify that the AuthenticationType is included on the POST /requestToPayTransfers
  • Verify that homeRTPtransactionId is added as an optional parameter to the POST \transactionRequest sync response
  • Verify that this end-to-end request to pay flow is functionally tested function

Tests

  • Functional Tests need to be added to test this use case.

Complexity: <High|Medium|Low> > A short comment to remind the reason for the rating

Uncertainty: <High|Medium|Low> > A short comment to remind the reason for the rating


Tasks:

  • API Snippets
    • SDK Outbound
      • Add PUT /requestToPay endpoint in SDK Outbound API in api-snippets
      • Rename homeTransactionId to homeR2PTransactionId in POST /requestToPay
      • Add Authentication type to POST \requestToPay to SDK Outbound
      • Rename requestToPayState to currentState in requestToPayResponse
      • Add getPartiesResponse in requestToPayResponse
      • Add transactionRequestResponse in requestToPayResponse
      • Remove authenticationType in requestToPayResponse
    • SDK Backend
      • Add authentication type to POST \transactionRequest
      • Rename the TransferAmount to TransactionRequestState
      • Add homeR2PTransactionId to POST \transactionRequest sync response
  • Payee Outbound
    • Implement PUT /requestToPay handler in SDK
    • Add config param AUTO_ACCEPT_R2P_PARTY to SDK and use it in requestToPay handlers
    • Add homeR2PTransactionId to corresponding handlers
    • Add Authentication type to POST /transactionRequests calls in requestToPay handlers
  • Payer Inbound
    • Add authentication type to FSPIOP inbound /transactionRequests to pass to the core backend
    • Rename the TransferAmount to TransactionRequestState
    • ?? Verify that the AuthenticationType is included on the POST /requestToPayTransfers
    • Add homeR2PTransactionId as an optional parameter to the POST \transactionRequest sync response

Done

  • Acceptance Criteria pass
  • Designs are up-to date
  • Unit Tests pass
  • Integration Tests pass
  • Code Style & Coverage meets standards
  • Changes made to config (default.json) are broadcast to team and follow-up tasks added to update helm charts and other deployment config.
  • TBD

Pull Requests:

Follow-up:

  • N/A

Dependencies:

  • N/A

Accountability:

  • Owner: TBC
  • QA/Review: TBC
@mdebarros
Copy link
Member

Hey team! Please add your planning poker estimate with Zenhub @PaulGregoryBaker @vijayg10

@PaulGregoryBaker PaulGregoryBaker changed the title [SDK Scheme Adaptor] Extend Payee requestToPay API process to support the validation of the payer details [SDK Scheme Adaptor] Extend Payee requestToPay API process to support the validation of the payer details (3pts) May 17, 2023
@vijayg10 vijayg10 self-assigned this May 17, 2023
@PaulGregoryBaker PaulGregoryBaker removed the to-be-refined This story is ready to be groomed label May 17, 2023
mdebarros added a commit to mojaloop/sdk-scheme-adapter that referenced this issue Jun 6, 2023
…t to Pay use case (#446)

feat(mojaloop/#3344): enhance SDK Scheme Adaptor to support the request to Pay use case - mojaloop/project#3344
- feat(mojaloop/#3345): Extend Payee requestToPay API process to support the validation of the payer details - mojaloop/project#3345
- feat(mojaloop/#3347): Enhance the requestToPayTransfer API process for Payer Acceptance flow - mojaloop/project#3347

---------

Co-authored-by: vijayg10 <33152110+vijayg10@users.noreply.github.com>
Co-authored-by: Vijay <vijaya.guthi@infitx.com>

---------

BREAKING CHANGE: Changes to the RequestToPay and RequestToPayTransfer operations to ensure alignment with the FSPIOP v1.1 specifications, see [SDK Backend API](mojaloop/api-snippets@v17.1.0...v17.2.0#diff-10028ebe8e69dc8dabdda64ce187e7e7aa953456b9f925a41bf7fdc91d0d8695), [SDK Outbound API](mojaloop/api-snippets@v17.1.0...v17.2.0#diff-18017d197f177e339457590d33522aad3ebb5181d6ea64c17325de039904bd8c), and [Design Documentation](mojaloop/documentation#413) for more information.
mdebarros added a commit to mojaloop/sdk-scheme-adapter that referenced this issue Jun 6, 2023
…st to Pay use case (#446)

feat(mojaloop/#3344): enhance SDK Scheme Adaptor to support the request to Pay use case - mojaloop/project#3344
- feat(mojaloop/#3345): Extend Payee requestToPay API process to support the validation of the payer details - mojaloop/project#3345
- feat(mojaloop/#3347): Enhance the requestToPayTransfer API process for Payer Acceptance flow - mojaloop/project#3347

fix: updates for nx v16 changes (#449)
- updated main nx.json config affected branch to `master`
- removed deprecated `--all` from all `nx affected` NPM scripts

BREAKING CHANGE: Changes to the RequestToPay and RequestToPayTransfer operations to ensure alignment with the FSPIOP v1.1 specifications, see [SDK Backend API](mojaloop/api-snippets@v17.1.0...v17.2.0#diff-10028ebe8e69dc8dabdda64ce187e7e7aa953456b9f925a41bf7fdc91d0d8695), [SDK Outbound API](mojaloop/api-snippets@v17.1.0...v17.2.0#diff-18017d197f177e339457590d33522aad3ebb5181d6ea64c17325de039904bd8c), and [Design Documentation](mojaloop/documentation#413) for more information.

---------

Co-authored-by: vijayg10 <33152110+vijayg10@users.noreply.github.com>
Co-authored-by: Vijay <vijaya.guthi@infitx.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants