Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SDK] Sdk-Scheme-Adapter config.transactionRequestsEndpoint is not being set correctly #3382

Closed
mdebarros opened this issue Jun 15, 2023 · 1 comment
Closed

[SDK] Sdk-Scheme-Adapter config.transactionRequestsEndpoint is not being set correctly #3382

mdebarros opened this issue Jun 15, 2023 · 1 comment
Assignees
@mdebarros
Labels
bug Something isn't working or it has wrong behavior on a Mojaloop Core service core-dev-squad oss-core This is an issue - story or epic related to a feature on a Mojaloop core service or related to it

Comments

@mdebarros
Copy link
Member

mdebarros commented Jun 15, 2023 •
edited
Loading

Summary:
Sdk-Scheme-Adapter config.transactionRequestsEndpoint is not being set correctly. Even though the env var TRANSACTION_REQUESTS_ENDPOINT is being set, when the OutboundRequestToPayModel is initialised, it will always use default localhost for the config.transactionRequestsEndpoint.

Severity:
High

Priority:
Medium

Expected Behavior

When env var TRANSACTION_REQUESTS_ENDPOINT is configured, the OutboundRequestToPayModel should be calling the POST /transactionRequests end-point with the the host specified in the env var.

Steps to Reproduce

  1. v23.0.0 of the SDK-Scheme-Adapter
  2. Execute the R2P Test Collection from TTKSim1

Specifications

  • Component (if known): SDK-Scheme-Adapter
  • Version: v23.0.0
  • Platform: n/a
  • Subsystem: n/a
  • Type of testing: n/a
  • Bug found/raised by: @mdebarros

Notes:

  • Severity when opened: High
  • Priority when opened: Medium
@mdebarros mdebarros added the bug Something isn't working or it has wrong behavior on a Mojaloop Core service label Jun 15, 2023
@mdebarros mdebarros changed the title [SDK] Sdk-Scheme-Adapter R2P [SDK] Sdk-Scheme-Adapter config.transactionRequestsEndpoint is not being set correctly Jun 15, 2023
@mdebarros mdebarros self-assigned this Jun 15, 2023
@mdebarros mdebarros added oss-core This is an issue - story or epic related to a feature on a Mojaloop core service or related to it core-dev-squad labels Jun 15, 2023
mdebarros added a commit to mdebarros/sdk-scheme-adapter that referenced this issue Jun 15, 2023
@mdebarros
fix(mojaloop/#3382): sdk-scheme-adapter config.trxReqEndpoint is not …
8725983 
…being set correctly

fix(mojaloop/#3382): sdk-scheme-adapter config.transactionRequestsEndpoint is not being set correctly - mojaloop/project#3382
- added missing config mapping for transactionRequestsEndpoint on OutboundRequestToPayModel
@mdebarros mdebarros mentioned this issue Jun 15, 2023
Merged
@mdebarros
Copy link
Member Author

PR to fix issue --> mojaloop/sdk-scheme-adapter#451

mdebarros added a commit to mojaloop/sdk-scheme-adapter that referenced this issue Jun 15, 2023
@mdebarros
fix(mojaloop/#3382): sdk-scheme-adapter config.trxReqEndpoint is not …
c29a81d 
…being set (#451)

fix(mojaloop/#3382): sdk-scheme-adapter config.transactionRequestsEndpoint is not being set correctly - mojaloop/project#3382
- added missing config mapping for transactionRequestsEndpoint on OutboundRequestToPayModel
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mdebarros mdebarros

Labels
bug Something isn't working or it has wrong behavior on a Mojaloop Core service core-dev-squad oss-core This is an issue - story or epic related to a feature on a Mojaloop core service or related to it
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mdebarros