Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node JS upgrade for the Third party API service #3521

Closed
12 of 14 tasks
PaulGregoryBaker opened this issue Sep 11, 2023 · 0 comments
Closed
12 of 14 tasks

Node JS upgrade for the Third party API service #3521

PaulGregoryBaker opened this issue Sep 11, 2023 · 0 comments
Assignees
@oderayi
Labels
core-dev-squad

Comments

@PaulGregoryBaker
Copy link

PaulGregoryBaker commented Sep 11, 2023 •
edited by oderayi
Loading

Tasks:

  • Update all dependencies
  • Verify that ignored dependency upgrades are still applicable .ncurc.yaml
  • Verify that ignored audit issues are still applicable audit-ci.jsonc
  • Update project to the latest LTS Nodejs version run CI tests
  • Update CI workflow based on the latest fixes made to the SDK-Scheme-Adapter CI workflow for NVM, etc.
  • Ensure all tests pass

Done

  • Acceptance Criteria pass
  • Designs are up-to date
  • Unit Tests pass
  • Integration Tests pass
  • Code Style & Coverage meets standards
  • Changes made to config (default.json) are broadcast to team and follow-up tasks added to update helm charts and other deployment config.

Pull Requests:

Follow-up:

  • N/A

Dependencies:

  • N/A

Accountability:

  • Owner: TBC
  • QA/Review: TBC
@oderayi oderayi self-assigned this Sep 14, 2023
@oderayi oderayi mentioned this issue Sep 15, 2023
Merged
oderayi added a commit to mojaloop/thirdparty-api-svc that referenced this issue Sep 20, 2023
@oderayi
chore(mojaloop/#3521): nodejs upgrade (#91)
0e7c958 
chore(mojaloop/#3521): NodeJS version upgrade - mojaloop/project#3521
- Upgraded nodejs from v16 to v18 LTS
- Applied CI changes as previously implemented in [sdk-scheme-adapter](mojaloop/sdk-scheme-adapter#453)
- Updated NPM dependencies
- Re-implement husky integration due to API changes in husky's latest version
- Resolved all audit issues
- Fixed docker-compose issues
- Migrated `master` branch to `main` branch
@oderayi oderayi closed this as completed Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oderayi oderayi

Labels
core-dev-squad
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@oderayi @PaulGregoryBaker