Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Batch Implementation - Improper error callbacks generated by switch #3582

Closed
2 of 3 tasks
Tracked by #3636
vijayg10 opened this issue Oct 18, 2023 · 2 comments
Closed
2 of 3 tasks
Tracked by #3636

Batch Implementation - Improper error callbacks generated by switch #3582

vijayg10 opened this issue Oct 18, 2023 · 2 comments
Assignees
Labels
bug Something isn't working or it has wrong behavior on a Mojaloop Core service core-dev-squad oss-core This is an issue - story or epic related to a feature on a Mojaloop core service or related to it PI-23

Comments

@vijayg10
Copy link

vijayg10 commented Oct 18, 2023

Summary:
The error callbacks generated by the switch are erroneous. Observed following issues

  • The error callback is sent as POST /transfers instead of PUT /transfers/{ID}
  • There is no transferID in the body for error callback and causing the validation error in FSP simulators {"missingProperty":"transferId"},"message":"must have required property 'transferId'"}
  • The source header should be set as switch

Accptance Criteria

  • Verify that the header code is compared to the non-batching handlers. There are other missing information that should be added.
  • Add unit test to validate the published kafka notification messages.

Severity:
(Low, Medium, High)

Priority:
Critical

Specifications

  • Component (if known): central position handler with batch processing
  • Version: feature branch for batch
  • Bug found/raised by: @vijayg10

PRs:

@vijayg10 vijayg10 added oss-core This is an issue - story or epic related to a feature on a Mojaloop core service or related to it bug Something isn't working or it has wrong behavior on a Mojaloop Core service labels Oct 18, 2023
@elnyry-sam-k
Copy link
Member

Critical when batching is enabled

@PaulGregoryBaker
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working or it has wrong behavior on a Mojaloop Core service core-dev-squad oss-core This is an issue - story or epic related to a feature on a Mojaloop core service or related to it PI-23
Projects
None yet
Development

No branches or pull requests

5 participants