Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HELM] Update Helm to enable deployment of batching #3577

Closed
5 of 16 tasks
PaulGregoryBaker opened this issue Oct 16, 2023 · 3 comments
Closed
5 of 16 tasks

[HELM] Update Helm to enable deployment of batching #3577

PaulGregoryBaker opened this issue Oct 16, 2023 · 3 comments
Assignees
@vijayg10
Labels
core-dev-squad PI-23 story

Comments

@PaulGregoryBaker
Copy link

PaulGregoryBaker commented Oct 16, 2023 •
edited by vijayg10
Loading

Goal:

As a Mojaloop Community member
I want to be able to deploy the latest batch improvements to the position handler
so that I can benefit from the performance gains and cost reductions

The latest batch position handler work allows the redirection of kafka messages to the new batch position handler through configuration. I.e. this functionality can be turned on or off through config.

Acceptance Criteria:

  • Verify that a helm value exists to configure the position handler events kafka topics
  • Verify that the batching position handler can be enabled through setting helm values
  • Verify that the batching position handler can be disabled through setting helm values

Complexity: <High|Medium|Low> > A short comment to remind the reason for the rating

Uncertainty: <High|Medium|Low> > A short comment to remind the reason for the rating

Tasks:

  • Add new service to helm
  • Add configuration for new kafka topics
  • Add to documentation which configs need to be changed to cofigure batching
  • Deploy the helm chart
  • test the GP

Done

  • Acceptance Criteria pass
  • Designs are up-to date
  • Unit Tests pass
  • Integration Tests pass
  • Code Style & Coverage meets standards
  • Changes made to config (default.json) are broadcast to team and follow-up tasks added to update helm charts and other deployment config.
  • TBD

Pull Requests:

Follow-up:

Dependencies:

  • N/A

Accountability:

  • Owner: TBC
  • QA/Review: TBC
@vijayg10 vijayg10 self-assigned this Oct 17, 2023
@PaulGregoryBaker PaulGregoryBaker removed the to-be-refined This story is ready to be groomed label Oct 17, 2023
@vijayg10
Copy link

On GP test run, observed 68 failures. Investigated the failures and understood that there are bugs in batch implementation. Created followup stories and included the references in the story.

Attached the TTK report for reference.
ttk-report.html.zip

@elnyry-sam-k
Copy link
Member

Thanks @vijayg10 , great work..

@mdebarros mdebarros mentioned this issue Oct 30, 2023
Merged
mdebarros added a commit to mojaloop/helm that referenced this issue Oct 30, 2023
@mdebarros @lucastmaior
@vijayg10 @aaronreynoza
feat(mojaloop/#3599): add support for custom annot to helm chart depl (…
0c9bdb2 
…#585)

feat(mojaloop/##3599): add support for custom annotations to helm chart deployments - mojaloop/project#3599
- added custom pod annotations to helm charts for deplyments/statefulsets
- added custom pod labels to helm charts for deployments/statefulsets

feat(mojaloop/3577): add batch handler - mojaloop/project#3577

chore: added CircleCI support for snapshot releases

---------

Co-authored-by: Lucas Viana <lucas.viana@tmaior.com.br>
Co-authored-by: Vijay <vijaya.guthi@infitx.com>
Co-authored-by: Aaron Reynoza <aaron.alejandro.reynoza@gmail.com>
@vijayg10
Copy link

vijayg10 commented Nov 7, 2023

Closing this story as the PR to be merged after resolving issues with batch impl.

@vijayg10 vijayg10 closed this as completed Nov 7, 2023
@JaneS321 JaneS321 added PI-23 and removed pi-22 labels Nov 7, 2023
@oderayi oderayi mentioned this issue Nov 17, 2023
Merged
oderayi pushed a commit to mojaloop/helm that referenced this issue Dec 5, 2023
@vijayg10
feat(mojaloop/#3577): add batch handler (#582)
cc9e1a3 
feat(mojaloop/#3577): add batch handler - mojaloop/project#3577
- Added  `BULK_TRANSFER` property to `EVENT_TYPE_ACTION_TOPIC_MAP` for routing `bulk-prepare` messages in `centralledger/chart-handler-transfer-prepare`
- Updated central-ledger version to include version with batch functionality
- Added configs for enabling/disabling batch functionality
- Added chart for batch functionality
- Updated README with instructions on batch functionality
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vijayg10 vijayg10

Labels
core-dev-squad PI-23 story
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@elnyry-sam-k @vijayg10 @PaulGregoryBaker @JaneS321