Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for custom annotation to helm chart deployments #3599

Closed
2 of 14 tasks
PaulGregoryBaker opened this issue Oct 26, 2023 · 0 comments
Closed
2 of 14 tasks

Add support for custom annotation to helm chart deployments #3599

PaulGregoryBaker opened this issue Oct 26, 2023 · 0 comments
Assignees
@mdebarros @aaronreynoza
Labels
core-dev-squad pi-22 story

Comments

@PaulGregoryBaker
Copy link

PaulGregoryBaker commented Oct 26, 2023 •
edited by mdebarros
Loading

Goal:

As a Hub deployer
I want to add support for custom annotations
so that we can set annotations on deployment to support capability like Istio

Acceptance Criteria:

  • Verify that each helm chart included in a mojaloop release supports custom annotations
    • Services (all ready done - please verify)
    • Ingress (all ready done - please verify)
    • deployments
    • stateful sets

Complexity: <High|Medium|Low> > A short comment to remind the reason for the rating

Uncertainty: <High|Medium|Low> > A short comment to remind the reason for the rating

Tasks:

  • TBD [ @? ]

Done

  • Acceptance Criteria pass
  • Designs are up-to date
  • Unit Tests pass
  • Integration Tests pass
  • Code Style & Coverage meets standards
  • Changes made to config (default.json) are broadcast to team and follow-up tasks added to update helm charts and other deployment config.
  • TBD

Pull Requests:

  • TBD

Follow-up:

  • N/A

Dependencies:

  • N/A

Accountability:

  • Owner: TBC
  • QA/Review: TBC
mdebarros added a commit to mojaloop/helm that referenced this issue Oct 26, 2023
@mdebarros
feat(mojaloop/##3599): add support for custom annot to helm chart depl
cdb21f2 
feat(mojaloop/##3599): add support for custom annot to helm chart depl - mojaloop/project#3599
- added custom pod annotations to
    - centralledger chart-service
    - ml-testing-toolkit chart-backend
@mdebarros mdebarros mentioned this issue Oct 26, 2023
Merged
@aaronreynoza aaronreynoza self-assigned this Oct 27, 2023
mdebarros added a commit to mojaloop/helm that referenced this issue Oct 30, 2023
@mdebarros @lucastmaior
@vijayg10 @aaronreynoza
feat(mojaloop/#3599): add support for custom annot to helm chart depl (…
0c9bdb2 
…#585)

feat(mojaloop/##3599): add support for custom annotations to helm chart deployments - mojaloop/project#3599
- added custom pod annotations to helm charts for deplyments/statefulsets
- added custom pod labels to helm charts for deployments/statefulsets

feat(mojaloop/3577): add batch handler - mojaloop/project#3577

chore: added CircleCI support for snapshot releases

---------

Co-authored-by: Lucas Viana <lucas.viana@tmaior.com.br>
Co-authored-by: Vijay <vijaya.guthi@infitx.com>
Co-authored-by: Aaron Reynoza <aaron.alejandro.reynoza@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mdebarros mdebarros

@aaronreynoza aaronreynoza

Labels
core-dev-squad pi-22 story
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mdebarros @aaronreynoza @PaulGregoryBaker @chris-me-law