Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/#769 additional party identifiers transaction scenarios #3

Conversation

HenkKodde
Copy link
Contributor

Included the additional seeds for PartyIdentifiers.
Included the additional seeds for TransactionScenarios.
Included Health check endpoint (verify database availability).
Updated release to 6.2.1.

Henk Kodde added 4 commits May 17, 2019 15:01
- updated references from Casablanca to Mowali in the licensing note.
…into feature/#769AditionalPartyIdentifiersTransactionScenarios
- update log messages.
- added health endpoint to verify database availability.
- updated on-boarding document to reflect health end point.
- added 'hapi-alive' package to package.json
- updated the release version from 6.2.0 to 6.2.1
Copy link
Member

@mdebarros mdebarros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comments.

Also please don't forget to update the version.

src/server.js Outdated Show resolved Hide resolved
src/server.js Outdated Show resolved Hide resolved
Copy link
Contributor

@rmothilal rmothilal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see comments

src/server.js Outdated Show resolved Hide resolved
src/server.js Outdated Show resolved Hide resolved
- Removed database health check from server.js as it added no value in the greater Mojaloop project.
- Updated dependencies in package.json file to latest.
Copy link
Contributor

@rmothilal rmothilal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please see comment

src/lib/config.js Outdated Show resolved Hide resolved
Copy link
Contributor

@rmothilal rmothilal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please see comments

src/interface/swagger.json Outdated Show resolved Hide resolved
- included error codes on the swagger.json file for health check.
@HenkKodde HenkKodde requested review from rmothilal and mdebarros May 23, 2019 16:28
Copy link
Contributor

@rmothilal rmothilal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy

@rmothilal rmothilal merged commit 67616af into mojaloop:master May 23, 2019
shashi165 pushed a commit that referenced this pull request Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants