Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mojaloop/#3933): update participant accounts validation #333

Merged
merged 21 commits into from
Jun 6, 2024

Conversation

oderayi
Copy link
Contributor

@oderayi oderayi commented May 29, 2024

mojaloop/project#3933

  • Added validation for supportedCurrencies when present in POST /quotes request (payer DFSP must have position account for all supported currencies
  • Added validation for payeeReceiveAmount currency when present (payee DFSP must have position account for the payeeReceiveAmount currency)
  • Fixed error handling to prevent sending double error callbacks
  • Ensure top-level tracing spans are finished correctly
  • Updated integration tests harness to support new changes
  • Added integration tests for the use case
  • Updated dependencies and resolve audit issues

@oderayi oderayi changed the base branch from main to feat/fx-impl May 29, 2024 13:39
@oderayi oderayi changed the title feat/#3933: update participant accounts validation feat(mojaloop/#3933): update participant accounts validation Jun 3, 2024
@oderayi oderayi marked this pull request as ready for review June 4, 2024 12:05
test/mocks.js Outdated Show resolved Hide resolved
docker/quoting-service/default.json Outdated Show resolved Hide resolved
src/model/fxQuotes.js Outdated Show resolved Hide resolved
src/model/fxQuotes.js Outdated Show resolved Hide resolved
src/model/quotes.js Outdated Show resolved Hide resolved
src/model/quotes.js Outdated Show resolved Hide resolved
src/model/quotes.js Outdated Show resolved Hide resolved
Copy link

sonarqubecloud bot commented Jun 5, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
26.6% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@oderayi oderayi merged commit 1b57edc into feat/fx-impl Jun 6, 2024
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants