Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mojaloop/3018): [SDK-Scheme-Adapter] TransactionId is being used instead of TransferId #422

Merged

Conversation

mdebarros
Copy link
Member

@mdebarros mdebarros commented Nov 11, 2022

feat(mojaloop/3018): [SDK-Scheme-Adapter] TransactionId is being used instead of TransferId - mojaloop/project#3018

  • bumped api-snippets to v17.0.0-snapshot.0 --> TODO: Upgrade this to final version once PR (feat(mojaloop/3018): [SDK-Scheme-Adapter] TransactionId is being used instead of TransferId api-snippets#148) has been merged
  • updated applicable events to include the transferId
  • updated aggregate handlers to correctly map the transferId instead of the transactionId
  • updated TTK API definitions for SDK Outbound API specifications (copied from API-Snippets)
  • updated TTK Test Case "bulk_happy_path_dynamic" to correctly use the transferId, and removed transactionId, bulkHomeTransactionId, homeTransactionId on PUT ACCEPT /bulkTransaction callbacks

chore: improvements to docker-compose for debugging

  • added "start:debug" to each of the modules to start with debugging enabled
  • updated docker-compose to use the "start:debug" command to be able to attach and debug issues

… instead of TransferId

feat(mojaloop/3018): [SDK-Scheme-Adapter] TransactionId is being used instead of TransferId - mojaloop/project#3018
- bumped api-snippets to v17.0.0-snapshot.0 --> TODO: Upgrade this to final version once PR (mojaloop/api-snippets#148) has been merged
- updated applicable events to include the transferId
- updated aggregate handlers to correctly map the transferId instead of the transactionId
- updated TTK API definitions for SDK Outbound API specifications (copied from API-Snippets)
- updated TTK Test Case "bulk_happy_path_dynamic" to correctly use the transferId instead of the transactionId

chore: improvements to docker-compose for debugging
- added "start:debug" to each of the modules to start with debugging enabled
- updated docker-compose to use the "start:debug" command to be able to attach and debug issues
@kleyow kleyow merged commit 5d349fe into master Nov 12, 2022
@kleyow kleyow deleted the feat/#3018-TransactionId-is-being-used-instead-of-TransferId branch November 12, 2022 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants