Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(oracle simulator): proper response on get participants with partySubIdOrType #215

Merged
merged 3 commits into from
Feb 9, 2021

Conversation

shashi165
Copy link
Contributor

@shashi165 shashi165 commented Feb 9, 2021

Summary

  1. Made the structure of the result of request GET oracle/participants/{Type}/{ID}?partySubIdOrType={SubId} to be consistent with the result of GET oracle/participants/{Type}/{ID}
    i.e.
{ 
  partyList: [ { fspId: 'testfsp2', currency: 'XOF', partySubIdOrType: undefined } ] 
} 

AND

{ 
   partyList: [ 
     { fspId: 'testfsp1', currency: 'XOF', partySubIdOrType: '10' }, 
     { fspId: 'testfsp1', currency: 'XOF', partySubIdOrType: '20' }, 
     { fspId: 'testfsp1', currency: 'XOF', partySubIdOrType: '30' }, 
     { fspId: 'testfsp1', currency: 'XOF', partySubIdOrType: '40' } 
   ] 
 } 

  1. Modified POST oracle/participants/{Type}/{ID} to allow multiple records to be created based on different partySubIdOrType. Earlier it was allowing to create only 1 record per {Type} and {ID} ignoring partySubIdOrType

Copy link
Contributor

@vgenev vgenev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants