Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(mojaloop/#3522): upgrade nodejs version #167

Merged
merged 52 commits into from
Sep 21, 2023
Merged

chore(mojaloop/#3522): upgrade nodejs version #167

merged 52 commits into from
Sep 21, 2023

Conversation

aaronreynoza
Copy link
Member

@aaronreynoza aaronreynoza commented Sep 13, 2023 •
edited
Loading

chore(mojaloop/#3522): nodejs upgrade - mojaloop/project#3522

  • Upgraded NodeJS from v16 to v18 LTS
  • Updated CI config to use NodeJS latest LTS version
  • Updated CI config to display runtime versions for each job
  • Upgraded NPM dependencies
  • Fixed CI bugs caused by the NodeJS upgrade
  • Updated CI pipeline use NVM to select node version from .nvmrc file
  • Upgraded circleci orbs
  • Migrated master branch to main
  • Optimized ci workflow to use cached image for some jobs
  • Upgraded Jest test which needed upgrade
  • Fix Husky hook

@aaronreynoza aaronreynoza mentioned this pull request Sep 19, 2023
Closed
12 tasks
@oderayi oderayi mentioned this pull request Sep 21, 2023
Closed
13 tasks
oderayi
oderayi requested changes Sep 21, 2023
View reviewed changes
Copy link
Contributor

@oderayi oderayi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

.circleci/config.yml Outdated Show resolved Hide resolved
.circleci/config.yml Outdated Show resolved Hide resolved
.circleci/config.yml Outdated Show resolved Hide resolved
.circleci/config.yml Outdated Show resolved Hide resolved
.circleci/config.yml Outdated Show resolved Hide resolved
oderayi
oderayi reviewed Sep 21, 2023
View reviewed changes
package.json Show resolved Hide resolved
oderayi
oderayi requested changes Sep 21, 2023
View reviewed changes
package.json Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
oderayi
oderayi approved these changes Sep 21, 2023
View reviewed changes
Copy link
Contributor

@oderayi oderayi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@aaronreynoza aaronreynoza merged commit a1b0523 into mojaloop:master Sep 21, 2023
@aaronreynoza aaronreynoza deleted the ML-3522 branch September 21, 2023 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kleyow kleyow kleyow approved these changes

@oderayi oderayi oderayi approved these changes

@mdebarros mdebarros Awaiting requested review from mdebarros

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aaronreynoza @oderayi @kleyow