Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flags not being displayed if using latest version of each library. #5

Open
ghost opened this issue Sep 17, 2019 · 8 comments · May be fixed by #11
Open

Flags not being displayed if using latest version of each library. #5

ghost opened this issue Sep 17, 2019 · 8 comments · May be fixed by #11
Labels
bug Something isn't working

Comments

@ghost
Copy link

ghost commented Sep 17, 2019

Hi there! Thanks for the work,

I just found that if you are using boostrap-select@1.13.10 and boostrap-select-country@4.1.0, the flags are not displayed (no error is reported in the console neither)

I tested it by using the example provided in the readme.

The modified example: https://jsbin.com/cinibug/edit?html,output
Hope this helps anyone who uses this library.

@mojoaxel mojoaxel added the bug Something isn't working label Sep 17, 2019
@mojoaxel
Copy link
Owner

@JoseAntonioIdener Thanks for reporting this! I need to look into this!

@chrisloughnane
Copy link

I just spent 2.5 hours banging my head of the wall with this.

@SlyDave
Copy link

SlyDave commented Jan 14, 2020

So glad I found this issue, before I spent the same amount of time as Chris!

@SlyDave
Copy link

SlyDave commented Jan 14, 2020

Here is a jsbin running Bootstrap 4 and latest version of everything:
https://jsbin.com/nucaxugato/edit?html,output

@devstack-be
Copy link

devstack-be commented Jan 29, 2020

@SlyDave For me, i can't see any flags on our URL;
I have the same problem as @chrisloughnane

@SlyDave
Copy link

SlyDave commented Jan 29, 2020

@SlyDave For me, i can't see any flags on our URL;
I have the same problem as @chrisloughnane

That jsbin isn't a fix, it's a example of the issue using the latest version of bootstrap and bootstrap-select-country. It has the same issue. I was just bringing it up to date. 👍

@devstack-be
Copy link

devstack-be commented Jan 29, 2020

I just now found the reason of the problem. The event $select.on('loaded.bs.select', function (e) {` is not triggered if the version of bootstrap-select is higher than 1.12.
Im looking for a fix

@mojoaxel
Copy link
Owner

mojoaxel commented Feb 8, 2020

I'm sorry but I currently have no time to fix this. But If anybody provides a pull-request IÄll try to review it as fast as possible!

mojoaxel pushed a commit that referenced this issue Feb 26, 2020
Fix is only in bootstrap-select-country.js
It must also be loaded into *.min.js file, but i do not know how :)
mojoaxel pushed a commit that referenced this issue Feb 26, 2020
Fix is only in bootstrap-select-country.js
It must also be loaded into *.min.js file, but i do not know how :)
@mojoaxel mojoaxel linked a pull request Feb 26, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants