Parallel execution of uptodate-properties #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@slachiewicz @slawekjaranowski @khmarbaise Kindly requesting your review. :-) |
slachiewicz
approved these changes
Mar 22, 2024
slawekjaranowski
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As
File::exists, just like obtaining a file's modification date, both are potentially blocking operations, huge file sets can slow down theuptodate-propertyanduptodate-propertiesMojos.A potential solution is to use several threads, so while the first thread is still blocked, another thread can take over the next uptodate-check. With multi-core CPUs being ubiquitous these days, such a rather small change can improve the build time considerably, in particular for huge projects with thousands of files and / or slows disks (like typically on NTFS). For single-core CPUs the drawback is neglectable.